On 5 Dec 2021, at 8:34, Eli Britstein via dev wrote:
> Following [1]-[3] in DPDK, there are no more such warnings from DPDK.
> Remove ignoring them if they occur.
>
> GitHub actions:
> v1: https://github.com/elibritstein/OVS/actions/runs/1540651133
>
> [1] a3f8d0587188 ("net: avoid cast-align warning in VLAN insert function")
> [2] da0333c8790b ("mbuf: avoid cast-align warning in data offset macro")
> [3] 6de430b7079e ("eal/x86: avoid cast-align warning in memcpy functions")
Changes look fine to me, maybe you can include the fixes tags to mention the
commits added these?!
Acked-by: Eelco Chaudron <[email protected]>
> Signed-off-by: Eli Britstein <[email protected]>
> ---
> .ci/linux-build.sh | 4 ----
> utilities/ovs-dev.py | 1 -
> 2 files changed, 5 deletions(-)
>
> diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
> index e20cc6ad0..65578880b 100755
> --- a/.ci/linux-build.sh
> +++ b/.ci/linux-build.sh
> @@ -226,10 +226,6 @@ if [ "$DPDK" ]; then
> DPDK_VER="20.11.1"
> fi
> install_dpdk $DPDK_VER
> - if [ "$CC" = "clang" ]; then
> - # Disregard cast alignment errors until DPDK is fixed
> - CFLAGS_FOR_OVS="${CFLAGS_FOR_OVS} -Wno-cast-align"
> - fi
> if [ -n "$DPDK_EXPERIMENTAL" ]; then
> CFLAGS_FOR_OVS="${CFLAGS_FOR_OVS} -DALLOW_EXPERIMENTAL_API"
> fi
> diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py
> index c45788acd..534c5e7f1 100755
> --- a/utilities/ovs-dev.py
> +++ b/utilities/ovs-dev.py
> @@ -90,7 +90,6 @@ def conf():
>
> if options.with_dpdk:
> configure.append("--with-dpdk=" + options.with_dpdk)
> - cflags += " -Wno-cast-align -Wno-bad-function-cast" # DPDK warnings.
Guess this script only works with older kernels due to always including the
--with-linux= option.
> if options.optimize is None:
> options.optimize = 0
> --
> 2.28.0.2311.g225365fb51
>
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
