On Tue, Jan 4, 2022 at 8:55 PM Ilya Maximets <[email protected]> wrote: > On 1/4/22 16:53, Eelco Chaudron wrote: > > On 4 Jan 2022, at 16:44, Eli Britstein wrote: > >> On 1/4/2022 4:56 PM, Eelco Chaudron wrote: > >>> On 5 Dec 2021, at 8:34, Eli Britstein via dev wrote: > >>> > >>>> Following [1]-[3] in DPDK, there are no more such warnings from DPDK. > >>>> Remove ignoring them if they occur. > >>>> > >>>> GitHub actions: > >>>> v1: https://github.com/elibritstein/OVS/actions/runs/1540651133 > >>>> > >>>> [1] a3f8d0587188 ("net: avoid cast-align warning in VLAN insert > >>>> function") > >>>> [2] da0333c8790b ("mbuf: avoid cast-align warning in data offset macro") > >>>> [3] 6de430b7079e ("eal/x86: avoid cast-align warning in memcpy > >>>> functions") > >>>
[snip] > Thanks, Eli and Eelco! > > Since we're already on 21.11, I rebased this patch and applied > directly to master. > > Speaking of cast-align, it would be great to have something like > this on the DPDK side: > > diff --git a/config/meson.build b/config/meson.build > index 805d5d51d0..4c47b2d63c 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -251,6 +251,7 @@ warning_flags = [ > '-Wextra', > > # additional warnings in alphabetical order > + '-Wcast-align', > '-Wcast-qual', > '-Wdeprecated', > '-Wformat', > --- > > But I don't know if that will cause any problems. This is something that DPDK had in the past, when building with make + gcc. It did not get to meson because of clang. https://git.dpdk.org/dpdk/commit?id=524a0d5d66b9a54242623aab9ace9ce4a7ec1347 On DPDK side, we would have to analyze/fix issues with clang, or enable this check only for gcc. Copied some people in case they have more input on this topic. -- David Marchand _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
