> -----Original Message-----
> From: Eelco Chaudron <[email protected]>
> Sent: Friday, January 14, 2022 10:03 AM
> To: Van Haaren, Harry <[email protected]>
> Cc: [email protected]; [email protected]
> Subject: Re: [ovs-dev] [PATCH] dpif-netdev: fix handling of vlan and ipv4
> parsing
> in avx512
<snip patch contents>
> > -#define PATTERN_IPV4_MASK PATTERN_IPV4_GEN(0xFF, 0xFE, 0xFF, 0xFF)
> > +#define PATTERN_IPV4_MASK PATTERN_IPV4_GEN(0xFF, 0xFF, 0xFF, 0xFF)
>
> I assume the original idea was not to include the may fragment bit, which I
> think
> should be fine to ignore.
Yes - good point.
> But the previous mask was 0xFE was masking of bit in the “Fragment offset”,
> so I
> think setting this to 0xDF would accomplish making sure this is not a
> fragment (or
> reserved bit set).
Yes - will validate and respin a v2.
> > #define PATTERN_IPV4_UDP PATTERN_IPV4_GEN(0x45, 0, 0, 0x11)
> > #define PATTERN_IPV4_TCP PATTERN_IPV4_GEN(0x45, 0, 0, 0x06)
> >
> > @@ -389,7 +389,7 @@ static const struct mfex_profile
> mfex_profiles[PROFILE_COUNT] =
> > .dp_pkt_offs = {
> > 14, UINT16_MAX, 18, 38,
> > },
> > - .dp_pkt_min_size = 46,
> > + .dp_pkt_min_size = 58,
>
> ACK
Thanks for review, -Harry
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
