Hi Eelco,

I have created a patch to add the warning to the system log
http://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/

I am not able to reproduce the warning, it will be good if you can test it and 
let me know if something more needs to be
Added here 

Regards
Amber

> -----Original Message-----
> From: Eelco Chaudron <[email protected]>
> Sent: Friday, February 4, 2022 2:54 PM
> To: Van Haaren, Harry <[email protected]>
> Cc: [email protected]; Ferriter, Cian <[email protected]>; Stokes,
> Ian <[email protected]>; [email protected]; Amber, Kumar
> <[email protected]>
> Subject: Re: [PATCH v3] dpif-netdev: fix vlan and ipv4 parsing in avx512
> 
> 
> 
> On 31 Jan 2022, at 14:54, Harry van Haaren wrote:
> 
> > This commit fixes the minimum packet size for the vlan/ipv4/tcp
> > traffic profile, which was previously incorrectly set.
> >
> > This commit also disallows any fragmented IPv4 packets from being
> > matched in the optimized miniflow-extract, avoiding complexity of
> > handling fragmented packets and using scalar fallback instead.
> > The DF (don't fragment) bit is now ignored, and stripped from the
> > resulting miniflow.
> >
> > Fixes: aa85a25095 ("dpif-netdev/mfex: Add more AVX512 traffic
> > profiles.")
> >
> > Signed-off-by: Harry van Haaren <[email protected]>
> >
> > ---
> 
> Hi Harry,
> 
> All the changes look good to me!
> 
> But with one exception :( I borrowed an AVX machine and I get the “OVS-DPDK -
> MFEX Autovalidator Fuzzy” test to fail every run.
> The cause is these log messages being present in the system log:
> 
> 
> +2022-02-04T09:09:45.705Z|00002|ofproto_dpif_upcall(pmd-
> c58/id:69)|WARN|upcall: datapath reached the dynamic limit of 10000 flows.
> +2022-02-04T09:09:45.705Z|00003|ofproto_dpif_upcall(pmd-
> c58/id:69)|WARN|upcall: datapath reached the dynamic limit of 10000 flows.
> +2022-02-04T09:09:45.705Z|00004|ofproto_dpif_upcall(pmd-
> c58/id:69)|WARN|upcall: datapath reached the dynamic limit of 10000 flows.
> +2022-02-04T09:09:45.705Z|00005|ofproto_dpif_upcall(pmd-
> c58/id:69)|WARN|upcall: datapath reached the dynamic limit of 10000 flows.
> +2022-02-04T09:09:45.705Z|00006|ofproto_dpif_upcall(pmd-
> c58/id:69)|WARN|upcall: datapath reached the dynamic limit of 10000 flows.
> 
> 
> I think this has nothing to do with this specific change, and it can be 
> easily fixed
> by adding this specific message to the OVS_VSWITCHD_STOP allowed logs for
> this specific test case.
> 
> Guess you can either fix it in this patchset, or a separate one, as without 
> the
> patch it’s also failing.
> 
> Acked-by: Eelco Chaudron <[email protected]>
> 
> Thanks,
> 
> Eelco
> 

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to