On 1/26/22 13:34, Adrian Moreno wrote: > Hi, > >>>> diff --git a/m4/openvswitch.m4 b/m4/openvswitch.m4 >>>> index 772825a71..192147ff5 100644 >>>> --- a/m4/openvswitch.m4 >>>> +++ b/m4/openvswitch.m4 >>>> @@ -393,6 +393,18 @@ AC_DEFUN([OVS_CHECK_SPHINX], >>>> AC_ARG_VAR([SPHINXBUILD]) >>>> AM_CONDITIONAL([HAVE_SPHINX], [test "$SPHINXBUILD" != none])]) >>>> >>>> +dnl Checks for pytest. >>>> +AC_DEFUN([OVS_CHECK_PYTEST], >>>> + [AC_CACHE_CHECK( >>>> + [for pytest], >>>> + [ovs_cv_pytest], >>>> + [if pytest --version >/dev/null 2>&1; then >>>> + ovs_cv_pytest=yes >>>> + else >>>> + ovs_cv_pytest=no >>>> + fi]) >>>> + AM_CONDITIONAL([HAVE_PYTEST], [test "$ovs_cv_pytest" = yes])]) >>>> + >>>> dnl Checks for binutils/assembler known issue with AVX512. >>>> dnl Due to backports, we probe assembling a reproducer instead of >>>> checking >>>> dnl binutils version string. More details, including ASM dumps and debug >>>> here: > > > Just FYI, In the new version, I'm changing this macro to check for all test > dependencies. >
Is pytest a build dependency or a test dependency? If it's only for testing, the check should, probably, be part of the tests/atlocal.in, which is executed every time before starting the testsuite. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
