On 1/28/22 13:40, Ilya Maximets wrote:
On 1/27/22 15:44, Adrian Moreno wrote:
On 1/26/22 14:45, Ilya Maximets wrote:
On 1/26/22 14:33, Adrian Moreno wrote:
On 1/26/22 13:43, Ilya Maximets wrote:
On 1/26/22 13:34, Adrian Moreno wrote:
Hi,
diff --git a/m4/openvswitch.m4 b/m4/openvswitch.m4
index 772825a71..192147ff5 100644
--- a/m4/openvswitch.m4
+++ b/m4/openvswitch.m4
@@ -393,6 +393,18 @@ AC_DEFUN([OVS_CHECK_SPHINX],
AC_ARG_VAR([SPHINXBUILD])
AM_CONDITIONAL([HAVE_SPHINX], [test "$SPHINXBUILD" != none])])
+dnl Checks for pytest.
+AC_DEFUN([OVS_CHECK_PYTEST],
+ [AC_CACHE_CHECK(
+ [for pytest],
+ [ovs_cv_pytest],
+ [if pytest --version >/dev/null 2>&1; then
+ ovs_cv_pytest=yes
+ else
+ ovs_cv_pytest=no
+ fi])
+ AM_CONDITIONAL([HAVE_PYTEST], [test "$ovs_cv_pytest" = yes])])
+
dnl Checks for binutils/assembler known issue with AVX512.
dnl Due to backports, we probe assembling a reproducer instead of checking
dnl binutils version string. More details, including ASM dumps and debug
here:
Just FYI, In the new version, I'm changing this macro to check for all test
dependencies.
Is pytest a build dependency or a test dependency?
If it's only for testing, the check should, probably,
be part of the tests/atlocal.in, which is executed
every time before starting the testsuite.
Hi Ilya, that's a good question. It's for testing but since I was
mimicking the flake8 tests, I have included them in the ALL_LOCAL
target. But I think it'd better if they are run as part of "make check",
right?
Yeah, flake8 is just a style check, while these are actual unit tests,
so should belong to a testsuite, I think.
Do you think it's better to add a new test as part of "testsuite.at" or create a new
"python-testsuite.at" and a new target, e.g: "make check-python"?
A benefit of the former is that it'll be integrated into the CI for free.
A benefit from the latter is that it'll be faster since there is no need to
build the entire project.
We're usually creating a special testsuite only if it's very inconvenient
to run these tests as part of the default one. For example, system tests
needs root privileges and modifies your system environment, ovsdb-cluster
tests are very heavy and require a lot of time and CPU resources to be
useful.
These python tests doesn't seem disruptive or heavy, so it's better to run
them by default on all platforms.
Understood, thanks Ilya.
--
Adrián Moreno
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
