> -----Original Message----- > From: Van Haaren, Harry <harry.van.haa...@intel.com> > Sent: Tuesday, February 8, 2022 10:17 AM > To: Eelco Chaudron <echau...@redhat.com>; Amber, Kumar > <kumar.am...@intel.com> > Cc: ovs-dev@openvswitch.org; Ferriter, Cian <cian.ferri...@intel.com>; Stokes, > Ian <ian.sto...@intel.com>; i.maxim...@ovn.org > Subject: RE: [PATCH v3] dpif-netdev: fix vlan and ipv4 parsing in avx512 > > Top posting summary/status of this patch; > 1) Code Acked by Eelco, Tested-by Amber > 2) Unit test Issue reported by Eelco below is being fixed in Amber's > patch/thread > here > > https://patchwork.ozlabs.org/project/openvswitch/patch/20220207110008.205 > 4074-1-kumar.am...@intel.com/ > > Patch should apply cleanly to 2.17 and 2.16. If required, I can backport a > 2.16 > version. > > I would like to see this getting merged soon, as the 2.17 release is planned > for > next week.
Thanks all for the reviews and testing on this, I've pushed this patch to master, 2.17 and 2.16. Thanks Ian > > > > -----Original Message----- > > From: Eelco Chaudron <echau...@redhat.com> > > Sent: Monday, February 7, 2022 11:44 AM > > To: Amber, Kumar <kumar.am...@intel.com> > > Cc: ovs-dev@openvswitch.org; Ferriter, Cian <cian.ferri...@intel.com>; > Stokes, > > Ian <ian.sto...@intel.com>; i.maxim...@ovn.org; Van Haaren, Harry > > <harry.van.haa...@intel.com> > > Subject: Re: [PATCH v3] dpif-netdev: fix vlan and ipv4 parsing in avx512 > > > > > > > > On 7 Feb 2022, at 12:41, Amber, Kumar wrote: > > > > > Hi Eelco, > > > > > > I have created a patch to add the warning to the system log > > > > > > http://patchwork.ozlabs.org/project/openvswitch/patch/20220207110008.2054 > 0 > > 74-1-kumar.am...@intel.com/ > > > > > > I am not able to reproduce the warning, it will be good if you can test > > > it and > let > > me know if something more needs to be > > > Added here > > > > I lost my AVX system, but the changes look good, so I acked it as it. > > > > //Eelco > > > > > > >> -----Original Message----- > > >> From: Eelco Chaudron <echau...@redhat.com> > > >> Sent: Friday, February 4, 2022 2:54 PM > > >> To: Van Haaren, Harry <harry.van.haa...@intel.com> > > >> Cc: ovs-dev@openvswitch.org; Ferriter, Cian <cian.ferri...@intel.com>; > > Stokes, > > >> Ian <ian.sto...@intel.com>; i.maxim...@ovn.org; Amber, Kumar > > >> <kumar.am...@intel.com> > > >> Subject: Re: [PATCH v3] dpif-netdev: fix vlan and ipv4 parsing in avx512 > > >> > > >> > > >> > > >> On 31 Jan 2022, at 14:54, Harry van Haaren wrote: > > >> > > >>> This commit fixes the minimum packet size for the vlan/ipv4/tcp > > >>> traffic profile, which was previously incorrectly set. > > >>> > > >>> This commit also disallows any fragmented IPv4 packets from being > > >>> matched in the optimized miniflow-extract, avoiding complexity of > > >>> handling fragmented packets and using scalar fallback instead. > > >>> The DF (don't fragment) bit is now ignored, and stripped from the > > >>> resulting miniflow. > > >>> > > >>> Fixes: aa85a25095 ("dpif-netdev/mfex: Add more AVX512 traffic > > >>> profiles.") > > >>> > > >>> Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com> > > >>> > > >>> --- > > >> > > >> Hi Harry, > > >> > > >> All the changes look good to me! > > >> > > >> But with one exception :( I borrowed an AVX machine and I get the “OVS- > > DPDK - > > >> MFEX Autovalidator Fuzzy” test to fail every run. > > >> The cause is these log messages being present in the system log: > > >> > > >> > > >> +2022-02-04T09:09:45.705Z|00002|ofproto_dpif_upcall(pmd- > > >> c58/id:69)|WARN|upcall: datapath reached the dynamic limit of 10000 > flows. > > >> +2022-02-04T09:09:45.705Z|00003|ofproto_dpif_upcall(pmd- > > >> c58/id:69)|WARN|upcall: datapath reached the dynamic limit of 10000 > flows. > > >> +2022-02-04T09:09:45.705Z|00004|ofproto_dpif_upcall(pmd- > > >> c58/id:69)|WARN|upcall: datapath reached the dynamic limit of 10000 > flows. > > >> +2022-02-04T09:09:45.705Z|00005|ofproto_dpif_upcall(pmd- > > >> c58/id:69)|WARN|upcall: datapath reached the dynamic limit of 10000 > flows. > > >> +2022-02-04T09:09:45.705Z|00006|ofproto_dpif_upcall(pmd- > > >> c58/id:69)|WARN|upcall: datapath reached the dynamic limit of 10000 > flows. > > >> > > >> > > >> I think this has nothing to do with this specific change, and it can be > > >> easily > fixed > > >> by adding this specific message to the OVS_VSWITCHD_STOP allowed logs > for > > >> this specific test case. > > >> > > >> Guess you can either fix it in this patchset, or a separate one, as > > >> without the > > >> patch it’s also failing. > > >> > > >> Acked-by: Eelco Chaudron <echau...@redhat.com> > > >> > > >> Thanks, > > >> > > >> Eelco > > >> > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
