On 23 Mar 2022, at 11:43, Abhiram R N wrote:
> When enabling offload for ERSPAN we are seeing one error as below
>
> netdev_offload_tc|INFO|init: failed to get ifindex for erspan0:
> Operation not supported
> netdev_offload|INFO|erspan0: No suitable flow API found.
>
> Adding the NETDEV_VPORT_GET_IFINDEX to ERSPAN device resolves this
> error
The change looks good to me, but there is no real unit test to verify this, and
I have no real setup to test this.
So based on a pure visible and compile only check:
Acked-by: Eelco Chaudron <[email protected]>
> Signed-off-by: Abhiram R N <[email protected]>
> ---
PS: Next time you send out an updated revision, please add some comments after
the --- above. For example something like:
v2:
- Removed terminating comma from final assignments.
> lib/netdev-vport.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
> index 64331f74b..3b3927865 100644
> --- a/lib/netdev-vport.c
> +++ b/lib/netdev-vport.c
> @@ -1245,7 +1245,8 @@ netdev_vport_tunnel_register(void)
> .type = "erspan",
> .build_header = netdev_erspan_build_header,
> .push_header = netdev_erspan_push_header,
> - .pop_header = netdev_erspan_pop_header
> + .pop_header = netdev_erspan_pop_header,
> + .get_ifindex = NETDEV_VPORT_GET_IFINDEX
> },
> {{NULL, NULL, 0, 0}}
> },
> @@ -1255,7 +1256,8 @@ netdev_vport_tunnel_register(void)
> .type = "ip6erspan",
> .build_header = netdev_erspan_build_header,
> .push_header = netdev_erspan_push_header,
> - .pop_header = netdev_erspan_pop_header
> + .pop_header = netdev_erspan_pop_header,
> + .get_ifindex = NETDEV_VPORT_GET_IFINDEX
> },
> {{NULL, NULL, 0, 0}}
> },
> --
> 2.27.0
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
