On 5 Apr 2022, at 0:48, Ilya Maximets wrote:
> On 3/23/22 14:01, Eelco Chaudron wrote: >> >> >> On 23 Mar 2022, at 11:43, Abhiram R N wrote: >> >>> When enabling offload for ERSPAN we are seeing one error as below >>> >>> netdev_offload_tc|INFO|init: failed to get ifindex for erspan0: >>> Operation not supported >>> netdev_offload|INFO|erspan0: No suitable flow API found. >>> >>> Adding the NETDEV_VPORT_GET_IFINDEX to ERSPAN device resolves this >>> error >> >> The change looks good to me, but there is no real unit test to verify this, >> and I have no real setup to test this. >> >> So based on a pure visible and compile only check: >> >> Acked-by: Eelco Chaudron <[email protected]> >> >>> Signed-off-by: Abhiram R N <[email protected]> >>> --- > > I don't see why this can cause any problems or why this callback > wasn't set from the beginning, so applied. Thanks! > > Best regards, Ilya Maximets. Hi Abhiram/Ilya, Guess it takes a while but basic ping seems to be failing when offloading to TC with t his change. If you enable TC offload the following tests are failing on latest master: datapath - ping over erspan v1 tunnel FAILED (system-traffic.at:467) datapath - ping over erspan v2 tunnel FAILED (system-traffic.at:504) datapath - ping over ip6erspan v1 tunnel FAILED (system-traffic.at:544) datapath - ping over ip6erspan v2 tunnel FAILED (system-traffic.at:585) For example the following diff causes the first test to fail with tc: diff --git a/tests/system-traffic.at b/tests/system-traffic.at index e16ea6027..fa6b84b4e 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -440,6 +440,9 @@ OVS_CHECK_GRE() OVS_CHECK_ERSPAN() OVS_TRAFFIC_VSWITCHD_START() + +ovs-vsctl --no-wait set Open_vSwitch . other_config:hw-offload=true + ADD_BR([br-underlay]) AT_CHECK([ovs-ofctl add-flow br0 "actions=normal"]) I think it’s because we are not adding any of the erspan fields to the offload tunnel encapsulated. Abhiram, wondering if this was really working in your case, as it seems only the first packet is passed on. I guess we might need to undo this change, or you need to come up with a fix for this. Cheers, Eelco _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
