On 27 May 2022, at 14:55, Eelco Chaudron wrote:
> On 10 May 2022, at 16:21, Emma Finn wrote: > >> This patchset introduces actions infrastructure changes which allows the >> user to choose between different action implementations based on CPU ISA >> by using different commands. The infrastructure also provides a way to >> check the correctness of the ISA optimized action version against the >> scalar version. >> >> This series also introduces optimized versions of the following actions: >> - push_vlan >> - pop_vlan >> - set_masked eth >> - set_masked ipv4 > > Hi Emma, > > Just to let you know, I’ve started to review your series, and I did some > performance testing on a none AVX512 machine, and the numbers look good, > i.e., all within the standard division of my PVP tests. I’m trying to get my > hands on an AVX512 machine and will do some more testing. > > In the meantime, I'll go over your changes, and I hope to get this done by > the end of next week. Hopefully, I also have an AVX512 machine and get a > chance to run some of the actual AVX code :) I forgot to add that I decided not to go over the five revisions of review history, so if I bring up something that was discussed before, please point me to the previous discussion/conclusion. > //Eelco _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
