> -----Original Message----- > From: Finn, Emma > Sent: Thursday 2 June 2022 16:00 > To: Eelco Chaudron <[email protected]> > Cc: Van Haaren, Harry <[email protected]>; Amber, Kumar > <[email protected]>; Stokes, Ian <[email protected]>; > [email protected] > Subject: RE: [v6 11/11] odp-execute: Add ISA implementation of > set_masked IPv4 action > > > > > -----Original Message----- > > From: Eelco Chaudron <[email protected]> > > Sent: Thursday 2 June 2022 15:43 > > To: Finn, Emma <[email protected]> > > Cc: Van Haaren, Harry <[email protected]>; Amber, Kumar > > <[email protected]>; Stokes, Ian <[email protected]>; > > [email protected] > > Subject: Re: [v6 11/11] odp-execute: Add ISA implementation of > > set_masked IPv4 action > > > > On 10 May 2022, at 16:22, Emma Finn wrote: > > > > > This commit adds support for the AVX512 implementation of the > > > ipv4_set_addrs action as well as an AVX512 implementation of > > > updating the checksums. > > > > > > Signed-off-by: Emma Finn <[email protected]> > > > --- > > > lib/odp-execute-avx512.c | 194 > > ++++++++++++++++++++++++++++++++++++++ > > > lib/odp-execute-private.c | 1 + > > > lib/odp-execute.c | 21 ++++- > > > 3 files changed, 211 insertions(+), 5 deletions(-) > > >
<snip> > > > > This completes my initial review of this series, let me know if > > something is not clear. I have not done any actual testing on an AVX > > machine, but I will try to do that on the next revision. > > > > Also, wondering how you tested performance on all of this? Maybe you > > can some details to the cover letter on how the relative performance > > numbers were gathered? Also wondering if you tested all of this > > without including DPDK in your build (it was/is on my TODO but I have > not AVX machine yet)? The relative performance numbers was only tested with OvS/DPDK, I did not test on OvS alone. Each action was tested individually, using a single PMD thread and a single flow like such $ ovs-ofctl add-flow br0 'in_port=1,ip,actions=mod_nw_ttl:254,output=2'. All other AVX components were disabled (DPCLS,MFEX,etc.) and traffic was sent at 100% line rate. > > > > Cheers, > > > > Eelco > > Hi Eelco, > > Thanks for the review. Will take the comments on board and start re > working for the next revision. > > Thanks, > Emma _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
