> -----Original Message-----
> From: Eelco Chaudron <[email protected]>
> Sent: Thursday 2 June 2022 15:32
> To: Finn, Emma <[email protected]>
> Cc: Van Haaren, Harry <[email protected]>; Amber, Kumar
> <[email protected]>; Stokes, Ian <[email protected]>;
> [email protected]
> Subject: Re: [v6 07/11] odp-execute: Add ISA implementation of actions.
>
> On 10 May 2022, at 16:21, Emma Finn wrote:
>
> > This commit adds the AVX512 implementation of the action functionality.
> >
> > Usage:
> > $ ovs-appctl dpif-netdev/action-impl-set avx512
> >
> > Signed-off-by: Emma Finn <[email protected]>
> > Acked-by: Harry van Haaren <[email protected]>
> > ---
> > Documentation/topics/dpdk/bridge.rst | 25 +++++++++++
> > Documentation/topics/testing.rst | 20 ++++++---
> > NEWS | 1 +
> > lib/automake.mk | 4 +-
> > lib/cpu.c | 1 +
> > lib/cpu.h | 1 +
> > lib/odp-execute-avx512.c | 67
> ++++++++++++++++++++++++++++
> > lib/odp-execute-private.c | 9 ++++
> > lib/odp-execute-private.h | 9 ++++
> > 9 files changed, 129 insertions(+), 8 deletions(-) create mode
> > 100644 lib/odp-execute-avx512.c
<snip>
> > diff --git a/lib/odp-execute-private.c b/lib/odp-execute-private.c
> > index 8f5f8723f..2bfa84152 100644
> > --- a/lib/odp-execute-private.c
> > +++ b/lib/odp-execute-private.c
> > @@ -46,6 +46,15 @@ static struct odp_execute_action_impl
> action_impls[] = {
> > .probe = NULL,
> > .init_func = odp_action_scalar_init,
> > },
> > +
> > + #if (__x86_64__ && HAVE_AVX512F && HAVE_LD_AVX512_GOOD
> &&
> > + __SSE4_2__)
>
> How about changing this instance to #ifdef ACTION_IMPL_AVX512? This
> way we only have one place where we have these compiler/arch checks.
>
V7 will not include a fix here, but we will investigate and report back to OVS
ML with results of investigation.
<snip>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
