Hi Amber/Emma, Thanks for the patch, couple of minor nits below.
> -----Original Message----- > From: dev <[email protected]> On Behalf Of Emma Finn > Sent: Thursday, July 7, 2022 9:09 PM > To: [email protected]; [email protected]; Van Haaren, Harry > <[email protected]>; Amber, Kumar <[email protected]> > Cc: [email protected] > Subject: [ovs-dev] [v8 05/10] dpif-netdev: Add configure option to enable > actions autovalidator at build time. I think the title should have "acinclude" instead of "dpif-netdev" here. > > From: Kumar Amber <[email protected]> > > This commit adds a new command to allow the user to enable the actions > autovalidator by default at build time thus allowing for running unit test > by default. > > $ ./configure --enable-actions-default-autovalidator > > Signed-off-by: Kumar Amber <[email protected]> > Acked-by: Harry van Haaren <[email protected]> > --- > NEWS | 2 ++ > acinclude.m4 | 21 +++++++++++++++++++++ > configure.ac | 1 + > lib/odp-execute.c | 4 ++++ > 4 files changed, 28 insertions(+) > > diff --git a/NEWS b/NEWS > index a279cbc29..607514874 100644 > --- a/NEWS > +++ b/NEWS > @@ -47,6 +47,8 @@ Post-v2.17.0 > implementations against default implementation. > * Add command line option to switch between different actions > implementations available at run time. > + * Add build time configure command to enable auto-validator as > default > + actions implementation at build time. > > > v2.17.0 - 17 Feb 2022 > diff --git a/acinclude.m4 b/acinclude.m4 index b518aa624..e63494e1d 100644 > --- a/acinclude.m4 > +++ b/acinclude.m4 > @@ -14,6 +14,27 @@ > # See the License for the specific language governing permissions and # > limitations under the License. > > +dnl Set OVS Actions Autovalidator as the default action implementation > +at compile time? Typo above - "?" instead of "." <snipped> Thanks and regards Sunil _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
