On 7/27/22 19:52, Pai G, Sunil wrote: > Hi Ilya, > > Thanks for both the patches. > I tested them on Ubuntu 22.04 (autoconf (GNU Autoconf) 2.71) as well as > Ubuntu 20.04 (autoconf (GNU Autoconf) 2.69) and both works as expected, > i.e don't see any warnings(except about AC_PROG_CC_C99) generated with > autoconf 2.71 after patch applied and no change in behavior for autoconf 2.69. > >> -----Original Message----- >> From: dev <[email protected]> On Behalf Of Ilya Maximets >> Sent: Wednesday, July 27, 2022 6:12 PM >> To: [email protected] >> Cc: Ilya Maximets <[email protected]> >> Subject: [ovs-dev] [PATCH 0/2] m4: Replace obsolete AC_HELP_STRING and >> AC_TRY_RUN. >> >> autoconf 2.70+ complais about these obsolete macros. >> Replacements are available in our baseline 2.63, so use them instead. >> >> It also complains about AC_PROG_CC_C99, but I'm not sure if we want to or >> how to correctly replace it. >> Suggested AC_PROG_CC enables C11 by default and that might not be a >> desired behavior. > > Not an expert in this area, but to ensure C99 support, the documentation > seems to point to having additional checks where required; particularly > checking cache variable ac_cv_prog_cc_c99 > https://www.gnu.org/software/autoconf/manual/autoconf-2.70/html_node/C-Compiler.html#AC_005fPROG_005fCC > > Seems we could borrow the idea used in this project: > https://github.com/lldpd/lldpd/blob/master/configure.ac ? > > Havent tried this though, so not sure if this really works.
We could do that, I guess. But that will not save us from the obsolescence warning, so I'm not sure if we need to touch that code. > >> >> Ilya Maximets (2): >> m4: Replace obsolete AC_HELP_STRING with AS_HELP_STRING. >> m4: Update ax_func_posix_memalign to the latest version. >> > > For the rest of the code changes on both patches, > > Acked-by: Sunil Pai G <[email protected]> Thanks! Applied and backported down to 2.17 to avoid possible problems on a future LTS branch. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
