On 8/17/22 13:45, yangchang wrote: > bond link status change comes from carrier and lacp may_enable ,when > carrir does not change and lacp change, prompt of LACP will be more accurate. > > Signed-off-by: yangchang <[email protected]> > --- > ofproto/bond.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/ofproto/bond.c b/ofproto/bond.c > index 845f69e21..b5b139e63 100644 > --- a/ofproto/bond.c > +++ b/ofproto/bond.c > @@ -1883,8 +1883,14 @@ bond_link_status_update(struct bond_member *member) > up = netdev_get_carrier(member->netdev) && member->may_enable; > if ((up == member->enabled) != (member->delay_expires == LLONG_MAX)) { > static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 20); > - VLOG_INFO_RL(&rl, "member %s: link state %s", > - member->name, up ? "up" : "down"); > + if (up == netdev_get_carrier(slave->netdev)) { > + VLOG_INFO_RL(&rl, "interface %s: link state %s", > + slave->name, up ? "up" : "down"); > + } else { > + VLOG_INFO_RL(&rl, "interface %s: lacp may_enable %s", > + slave->name, up ? "true" : "false"); > + } > + > if (up == member->enabled) { > member->delay_expires = LLONG_MAX; > VLOG_INFO_RL(&rl, "member %s: will not be %s", > -- > 2.27.0.windows.1
[email protected] Hi, yangchang. Thanks for the patch! Though it looks similar to what Mike did in his broader logging update here: https://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/ It would be great if you can help with testing/reviewing that change. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
