Bleep bloop. Greetings yangchang, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#24 FILE: ofproto/bond.c:1896:
if (up == netdev_get_carrier(member>netdev)) {
Lines checked: 38, Warnings: 1, Errors: 0
build:
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare
-Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
-Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
-Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow
-Werror -Wno-unused -Wno-unused-parameter -g -O2 -MT
lib/lib_libsflow_la-sflow_agent.lo -MD -MP -MF
lib/.deps/lib_libsflow_la-sflow_agent.Tpo -c lib/sflow_agent.c -o
lib/lib_libsflow_la-sflow_agent.o
mv -f lib/.deps/lib_libsflow_la-sflow_agent.Tpo
lib/.deps/lib_libsflow_la-sflow_agent.Plo
/bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.
-I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall
-Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
-Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
-Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror
-Wno-unused -Wno-unused-parameter -g -O2 -MT
lib/lib_libsflow_la-sflow_sampler.lo -MD -MP -MF
lib/.deps/lib_libsflow_la-sflow_sampler.Tpo -c -o
lib/lib_libsflow_la-sflow_sampler.lo `test -f 'lib/sflow_sampler.c' || echo
'./'`lib/sflow_sampler.c
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare
-Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
-Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
-Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow
-Werror -Wno-unused -Wno-unused-parameter -g -O2 -MT
lib/lib_libsflow_la-sflow_sampler.lo -MD -MP -MF
lib/.deps/lib_libsflow_la-sflow_sampler.Tpo -c lib/sflow_sampler.c -o
lib/lib_libsflow_la-sflow_sampler.o
mv -f lib/.deps/lib_libsflow_la-sflow_sampler.Tpo
lib/.deps/lib_libsflow_la-sflow_sampler.Plo
/bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.
-I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall
-Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
-Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
-Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror
-Wno-unused -Wno-unused-parameter -g -O2 -MT
lib/lib_libsflow_la-sflow_poller.lo -MD -MP -MF
lib/.deps/lib_libsflow_la-sflow_poller.Tpo -c -o
lib/lib_libsflow_la-sflow_poller.lo `test -f 'lib/sflow_poller.c' || echo
'./'`lib/sflow_poller.c
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare
-Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
-Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
-Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow
-Werror -Wno-unused -Wno-unused-parameter -g -O2 -MT
lib/lib_libsflow_la-sflow_poller.lo -MD -MP -MF
lib/.deps/lib_libsflow_la-sflow_poller.Tpo -c lib/sflow_poller.c -o
lib/lib_libsflow_la-sflow_poller.o
mv -f lib/.deps/lib_libsflow_la-sflow_poller.Tpo
lib/.deps/lib_libsflow_la-sflow_poller.Plo
/bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.
-I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall
-Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
-Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
-Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror
-Wno-unused -Wno-unused-parameter -g -O2 -MT
lib/lib_libsflow_la-sflow_receiver.lo -MD -MP -MF
lib/.deps/lib_libsflow_la-sflow_receiver.Tpo -c -o
lib/lib_libsflow_la-sflow_receiver.lo `test -f 'lib/sflow_receiver.c' || echo
'./'`lib/sflow_receiver.c
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare
-Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
-Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
-Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow
-Werror -Wno-unused -Wno-unused-parameter -g -O2 -MT
lib/lib_libsflow_la-sflow_receiver.lo -MD -MP -MF
lib/.deps/lib_libsflow_la-sflow_receiver.Tpo -c lib/sflow_receiver.c -o
lib/lib_libsflow_la-sflow_receiver.o
mv -f lib/.deps/lib_libsflow_la-sflow_receiver.Tpo
lib/.deps/lib_libsflow_la-sflow_receiver.Plo
/bin/sh ./libtool --tag=CC --mode=link gcc -std=gnu99 -Wstrict-prototypes
-Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
-Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
-Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror
-Wno-unused -Wno-unused-parameter -g -O2 -release 3.0 -version-info 0:90
-Wl,--version-script=./lib/libsflow.sym -o lib/libsflow.la -rpath
/usr/local/lib lib/lib_libsflow_la-sflow_agent.lo
lib/lib_libsflow_la-sflow_sampler.lo lib/lib_libsflow_la-sflow_poller.lo
lib/lib_libsflow_la-sflow_receiver.lo -lpthread -lrt -lm -lunbound
libtool: link: ar cru lib/.libs/libsflow.a lib/lib_libsflow_la-sflow_agent.o
lib/lib_libsflow_la-sflow_sampler.o lib/lib_libsflow_la-sflow_poller.o
lib/lib_libsflow_la-sflow_receiver.o
libtool: link: ranlib lib/.libs/libsflow.a
libtool: link: ( cd "lib/.libs" && rm -f "libsflow.la" && ln -s
"../libsflow.la" "libsflow.la" )
/bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.
-I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall
-Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
-Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
-Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
-Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -g -O2 -MT
ofproto/ofproto_libofproto_la-bond.lo -MD -MP -MF
ofproto/.deps/ofproto_libofproto_la-bond.Tpo -c -o
ofproto/ofproto_libofproto_la-bond.lo `test -f 'ofproto/bond.c' || echo
'./'`ofproto/bond.c
libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include
-I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare
-Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
-Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
-Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow
-Werror -g -O2 -MT ofproto/ofproto_libofproto_la-bond.lo -MD -MP -MF
ofproto/.deps/ofproto_libofproto_la-bond.Tpo -c ofproto/bond.c -o
ofproto/ofproto_libofproto_la-bond.o
ofproto/bond.c: In function 'bond_link_status_update':
ofproto/bond.c:1896:45: error: 'netdev' undeclared (first use in this function)
if (up == netdev_get_carrier(member>netdev)) {
^
ofproto/bond.c:1896:45: note: each undeclared identifier is reported only once
for each function it appears in
make[1]: *** [ofproto/ofproto_libofproto_la-bond.lo] Error 1
make[1]: Leaving directory
`/var/lib/jenkins/jobs/0day_robot_upstream_build_from_pw/workspace'
make: *** [all] Error 2
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
