On 8/31/22 13:34, Eelco Chaudron wrote:
>
>
> On 31 Aug 2022, at 12:25, Ilya Maximets wrote:
>
>> If tnl_port_should_receive() is false, we're looking for a normal
>> port, not a tunnel one. And it's better to print recirculation IDs
>> in hex since they are typically printed this way in flow dumps.
>>
>> Fixes: d40533fc820c ("odp-util: Improve log messages and error reporting for
>> Netlink parsing.")
>> Signed-off-by: Ilya Maximets <[email protected]>
>
> Changes look good to me with one small nit below. Compile and make check
> tested.
>
> Acked-by: Eelco Chaudron <[email protected]>
>
> //Eelco
>
>> ---
>> ofproto/ofproto-dpif-xlate.c | 4 ++--
>> tests/ofproto-dpif.at | 14 ++++++++++++++
>> 2 files changed, 16 insertions(+), 2 deletions(-)
>>
>> diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
>> index fda802e83..5c3021765 100644
>> --- a/ofproto/ofproto-dpif-xlate.c
>> +++ b/ofproto/ofproto-dpif-xlate.c
>> @@ -1515,7 +1515,7 @@ xlate_lookup_ofproto_(const struct dpif_backer *backer,
>> if (OVS_UNLIKELY(!recirc_id_node)) {
>> if (errorp) {
>> *errorp = xasprintf("no recirculation data for recirc_id "
>> - "%"PRIu32, flow->recirc_id);
>> + "%#"PRIx32, flow->recirc_id);
>> }
>> return NULL;
>> }
>> @@ -1556,7 +1556,7 @@ xlate_lookup_ofproto_(const struct dpif_backer *backer,
>> if (errorp) {
>> *errorp = (tnl_port_should_receive(flow)
>> ? xstrdup("no OpenFlow tunnel port for this packet")
>> - : xasprintf("no OpenFlow tunnel port for datapath "
>> + : xasprintf("no OpenFlow port for datapath "
>> "port %"PRIu32, flow->in_port.odp_port));
>
> nit: should we move port to the previous line now that we have room, it makes
> grep for strings easier?
>
> Something like:
>
> + : xasprintf("no OpenFlow port for datapath port %"
> + PRIu32, flow->in_port.odp_port));
I did that, but I kept the '%' on the next line, it belongs to PRIu32.
With that, applied and backported down to 2.17.
Thanks!
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
