Hey Maxime/Kevin, I have posted a single patch for updating to 21.11.2 directed for master. The link to the patch is: http://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/.
I have added some notes in the NEWS file and commit message on the issues with DPDK 21.11.2 as you suggested. I would appreciate your feedback on the formatting of these and once the format is agreed on I can create the patches for the other branches and publish them to the mailing list. Thanks in advance, Michael. > -----Original Message----- > From: Maxime Coquelin <[email protected]> > Sent: Thursday 15 September 2022 11:09 > To: Phelan, Michael <[email protected]>; Kevin Traynor > <[email protected]>; [email protected]; [email protected] > Cc: David Marchand <[email protected]> > Subject: Re: [ovs-dev] [PATCH] dpdk: Use DPDK 21.11.2 release. > > > > On 9/15/22 11:51, Phelan, Michael wrote: > > Hi Kevin/Maxime, > > Thanks for the update, that sounds good to me. I am also working on > validating OVS 2.13 and 2.14 with DPDK 19.11.13 and have patches ready to go > to move to the new version. > > > > Do we know if this issue is present in DPDK 19.11.13? > > Yes, it is in since v19.11.12, this is the faulty commit: > 1e68fe334ff0 ("vhost: fix unsafe vring addresses modifications") > > It is also in v20.11 LTS since v20.11.5: > 33f2e3756186 ("vhost: fix unsafe vring addresses modifications") > > Regards, > Maxime > > > Thanks, > > Michael. > > > > > >> -----Original Message----- > >> From: Maxime Coquelin <[email protected]> > >> Sent: Thursday 15 September 2022 09:35 > >> To: Kevin Traynor <[email protected]>; [email protected]; Phelan, > >> Michael <[email protected]>; [email protected] > >> Cc: David Marchand <[email protected]> > >> Subject: Re: [ovs-dev] [PATCH] dpdk: Use DPDK 21.11.2 release. > >> > >> > >> > >> On 9/15/22 10:27, Kevin Traynor wrote: > >>> Hi Michael/Maxime, > >>> > >>> On 14/09/2022 16:53, Kevin Traynor wrote: > >>>> On 14/09/2022 16:18, Maxime Coquelin wrote: > >>>>> Hi Kevin, > >>>>> > >>>>> On 9/14/22 16:14, Kevin Traynor wrote: > >>>>>> Hi Maxime, > >>>>>> > >>>>>> On 14/09/2022 15:45, Maxime Coquelin wrote: > >>>>>>> Hi, > >>>>>>> > >>>>>>> On 9/8/22 13:15, Michael Phelan wrote: > >>>>>>>> CI Linux build script updated to use DPDK version 21.11.2. > >>>>>>>> Documentation updated to use DPDK version 21.11.2. > >>>>>>>> NEWS entry added for DPDK 21.11.2 validation. > >>>>>>>> Updated FAQ to recommend use of DPDK version 21.11.2. > >>>>>>> > >>>>>>> For your information, we just discovered a regression in Vhost > >>>>>>> library introduced in v21.11.2. > >>>>>>> > >>>>>> > >>>>>> The commit listed as being fixed was itself backported to > >>>>>> 21.11.1, which is the one currently documented as supported with > >>>>>> OVS master and branch-3.0. > >>>>>> > >>>>>> Is it as likely to occur with 21.11.1, or there is some other > >>>>>> in-direct changes in 21.11.2 that make it trigger ? > >>>>> > >>>>> My mistake, you are right it landed in v21.11.1. > >>>>> I think it can be triggered with v21.11.1 too, as long as NUMA > >>>>> reallocation happens and vIOMMU is enabled. > >>>>> > >>>>> So, in that case, it does not block us to move to v21.11.2. > >>>>> Should we document this issue somewhere? > >>>>> > >>>> > >>>> We could put a link to a Bz and brief explanation in the NEWS item > >>>> (see below). > >>>> > >>>> If we move to 21.11.2, we gain ~300 fixes including the vhost and > >>>> Mlx CVEs but keep this NUMA issue. > >>>> > >>>> If we move back to 21.11.0, we lose ~400 fixes and we don't get the > >>>> CVE fixes, but this NUMA issue is resolved. > >>>> > >>>> Considering the CVE fixes, moving to 21.11.2 and documenting this > >>>> NUMA issue seems the best approach to me. > >>>> > >>> > >>> We chatted about this on the OVS public call yesterday. The > >>> consensus on the call was to go ahead with these updates (to 20.11.6 > >>> and > >>> 21.11.2) but to document/link to the known NUMA issue and CVE fixes, > >>> so a user could then make an informed choice about which DPDK > >>> version to use depending on their use cases. Of course it can be > >>> discussed more if people disagree with this approach. > >>> > >>> We can also apply to the fix to the DPDK LTS branches shortly after > >>> they land in DPDK main branch, so anyone pulling the latest branches > >>> will have both sets of fixes included. > >> > >> Thanks for the update, that sounds like a good plan to me. > >> I'll send a patch to document the issue. > >> > >> Maxime > >> > >>> thanks, > >>> Kevin. > >>> > >>>>> Thanks for the correction, > >>>>> Maxime > >>>>> > >>>>>> > >>>>>>> A deadlock happens when vIOMMU is enabled and NUMA > >> reallocation of > >>>>>>> the virtqueues happen. A fix [0] was already posted by David in > >>>>>>> July and will soon land into DPDK main branch, so it will likely > >>>>>>> be in v21.11.3 release. > >>>>>>> > >>>>>> > >>>>>> It sounds nasty enough - assuming there is enough in 21.11.1 to > >>>>>> trigger this, perhaps we should downgrade the > >> documented/supported > >>>>>> version for > >>>>>> master/branch-3.0 to 21.11.0 until there is a fix in 21.11.3. > >>>>>> > >>>>>>> Maxime > >>>>>>> > >>>>>>> [0]: > >>>>>>> > >> http://patches.dpdk.org/project/dpdk/patch/20220725203206.427083-2 > >>>>>>> [email protected]/ > >>>>>>> > >>>>>>> > >>>>>>>> Signed-off-by: Michael Phelan <[email protected]> > >>>>>>>> --- > >>>>>>>> .ci/linux-build.sh | 2 +- > >>>>>>>> Documentation/faq/releases.rst | 2 +- > >>>>>>>> Documentation/intro/install/dpdk.rst | 8 ++++---- > >>>>>>>> NEWS | 3 +++ > >>>>>>>> 4 files changed, 9 insertions(+), 6 deletions(-) > >>>>>>>> > >>>>>>>> diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index > >>>>>>>> 509314a07..23c8bbb7a 100755 > >>>>>>>> --- a/.ci/linux-build.sh > >>>>>>>> +++ b/.ci/linux-build.sh > >>>>>>>> @@ -228,7 +228,7 @@ fi > >>>>>>>> if [ "$DPDK" ] || [ "$DPDK_SHARED" ]; then > >>>>>>>> if [ -z "$DPDK_VER" ]; then > >>>>>>>> - DPDK_VER="21.11.1" > >>>>>>>> + DPDK_VER="21.11.2" > >>>>>>>> fi > >>>>>>>> install_dpdk $DPDK_VER > >>>>>>>> fi > >>>>>>>> diff --git a/Documentation/faq/releases.rst > >>>>>>>> b/Documentation/faq/releases.rst index 1bc22a6ba..d138091c1 > >>>>>>>> 100644 > >>>>>>>> --- a/Documentation/faq/releases.rst > >>>>>>>> +++ b/Documentation/faq/releases.rst > >>>>>>>> @@ -215,7 +215,7 @@ Q: What DPDK version does each Open > >> vSwitch > >>>>>>>> release work with? > >>>>>>>> 2.15.x 20.11.4 > >>>>>>>> 2.16.x 20.11.4 > >>>>>>>> 2.17.x 21.11.1 > >>>>>>>> - 3.0.x 21.11.1 > >>>>>>>> + 3.0.x 21.11.2 > >>>>>>>> ============ ======== > >>>>>>>> Q: Are all the DPDK releases that OVS versions work with > >>>>>>>> maintained? > >>>>>>>> diff --git a/Documentation/intro/install/dpdk.rst > >>>>>>>> b/Documentation/intro/install/dpdk.rst > >>>>>>>> index 0f3712c79..a284e6851 100644 > >>>>>>>> --- a/Documentation/intro/install/dpdk.rst > >>>>>>>> +++ b/Documentation/intro/install/dpdk.rst > >>>>>>>> @@ -42,7 +42,7 @@ Build requirements > >>>>>>>> In addition to the requirements described in > >>>>>>>> :doc:`general`, building Open > >>>>>>>> vSwitch with DPDK will require the following: > >>>>>>>> -- DPDK 21.11.1 > >>>>>>>> +- DPDK 21.11.2 > >>>>>>>> - A `DPDK supported NIC`_ @@ -73,9 +73,9 @@ Install DPDK > >>>>>>>> #. Download the `DPDK sources`_, extract the file and set > >>>>>>>> ``DPDK_DIR``:: > >>>>>>>> $ cd /usr/src/ > >>>>>>>> - $ wget https://fast.dpdk.org/rel/dpdk-21.11.1.tar.xz > >>>>>>>> - $ tar xf dpdk-21.11.1.tar.xz > >>>>>>>> - $ export DPDK_DIR=/usr/src/dpdk-stable-21.11.1 > >>>>>>>> + $ wget https://fast.dpdk.org/rel/dpdk-21.11.2.tar.xz > >>>>>>>> + $ tar xf dpdk-21.11.2.tar.xz > >>>>>>>> + $ export DPDK_DIR=/usr/src/dpdk-stable-21.11.2 > >>>>>>>> $ cd $DPDK_DIR > >>>>>>>> #. Configure and install DPDK using Meson diff --git > >>>>>>>> a/NEWS b/NEWS index 53594cbbd..1fffd5e42 100644 > >>>>>>>> --- a/NEWS > >>>>>>>> +++ b/NEWS > >>>>>>>> @@ -1,5 +1,8 @@ > >>>>>>>> Post-v3.0.0 > >>>>>>>> -------------------- > >>>>>>>> +- DPDK: > >>>>>>>> + * OVS validated with DPDK 21.11.2. It is recommended to > >>>>>>>> +use > >>>>>>>> this version > >>>>>>>> + until further releases. > >>>> > >>>> ^^^ add a note here > >>>> > >>>>>>>> v3.0.0 - 15 Aug 2022 > >>>>>>> > >>>>>>> _______________________________________________ > >>>>>>> dev mailing list > >>>>>>> [email protected] > >>>>>>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev > >>>>>>> > >>>>>> > >>>>> > >>>> > >>> > > > > _______________________________________________ > > dev mailing list > > [email protected] > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
