> -----Original Message-----
> From: dev <[email protected]> On Behalf Of Kumar Amber
> Sent: Friday, August 26, 2022 5:01 AM
> To: [email protected]
> Cc: [email protected]; [email protected]; Amber, Kumar
> <[email protected]>
> Subject: [ovs-dev] [PATCH v5 1/9] dpif-netdev: Refactor per thread recirc
> data allocation.
> 
> The refactor allows us to use *recirc_depth_get() to obtain the depth
> across ovs which was previously limited to only dpif-netdev.c.
> 
> Signed-off-by: Kumar Amber <[email protected]>
> Signed-off-by: Cian Ferriter <[email protected]>
> Co-authored-by: Cian Ferriter <[email protected]>
> Acked-by: Harry van Haaren <[email protected]>
> ---
>  lib/dpif-netdev-private-dpif.c | 2 ++
>  lib/dpif-netdev-private-dpif.h | 5 +++++
>  lib/dpif-netdev.c              | 3 ---
>  3 files changed, 7 insertions(+), 3 deletions(-)
> 

Hi Amber, 

I would prefer if you mentioned the intent behind this patch in the commit 
message. [the cover letter doesn’t get applied].
Example: This is a precursor to enabling ...

Otherwise, the changes look good to me, I'm happy to ack.

Acked-by: Sunil Pai G <[email protected]>

Thanks and regards
Sunil
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to