Hi Sunil, Sure, have added the comments in the commit log.
Regards Amber > -----Original Message----- > From: Pai G, Sunil <[email protected]> > Sent: Tuesday, October 4, 2022 12:32 PM > To: Amber, Kumar <[email protected]>; [email protected] > Cc: [email protected]; [email protected]; Amber, Kumar > <[email protected]> > Subject: RE: [ovs-dev] [PATCH v5 2/9] dpif-netdev: Refactor hash function to > own header. > > > > > -----Original Message----- > > From: dev <[email protected]> On Behalf Of Kumar > Amber > > Sent: Friday, August 26, 2022 5:01 AM > > To: [email protected] > > Cc: [email protected]; [email protected]; Amber, Kumar > > <[email protected]> > > Subject: [ovs-dev] [PATCH v5 2/9] dpif-netdev: Refactor hash function > > to own header. > > > > The refactor allows us to use hash function accross multiple files > > which was earlier restricted to dpif-netdev.c only. > > > > Signed-off-by: Kumar Amber <[email protected]> > > Signed-off-by: Cian Ferriter <[email protected]> > > Co-authored-by: Cian Ferriter <[email protected]> > > > > --- > > v3: > > - Fix minor comments from Harry. > > --- > > --- > > lib/dpif-netdev-private-dpcls.h | 23 +++++++++++++++++++++++ > > lib/dpif-netdev.c | 22 ---------------------- > > 2 files changed, 23 insertions(+), 22 deletions(-) > > > > Hi Amber, > > Patch looks good to me; but..like patch 1, I would prefer if you mentioned > why this change is required in the commit message. > > Acked-by: Sunil Pai G <[email protected]> > > Thanks and regards > Sunil _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
