On 26/10/2022 11:38, Simon Horman wrote:
> On Sun, Oct 23, 2022 at 09:27:10AM +0300, Roi Dayan wrote:
>> OVN is setting ct drop rule with a ct clear action.
>> OVS datapath behavior is if there is no forward action
>> the default is drop.
>> TC behavior is to continue with next match.
>> Fix to match tc to ovs behavior by setting last action
>> attribute as drop instead of pipe.
>
> This change looks good to me.
> And we will try to exercise it.
>
>> Also update lastused when parsing ct action.
>
> Could you split this into a separate patch?
> It seems like a distinct change.
>
it's kind of related. now CT is last action so we update the stats.
we only use the stats on the last action. i.e. drop, fwd.
do you still want to separate?
>> example rule
>> recirc_id(0x1),in_port(2),ct_state(+trk),eth(),eth_type(0x0800),ipv4(frag=no),
>> packets:82, bytes:8036, used:2.108s, actions:ct_clear
>>
>> Reviewed-by: Maor Dickman <[email protected]>
>> Signed-off-by: Roi Dayan <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
