On Mon, Oct 31, 2022 at 11:22:48AM +0100, Simon Horman wrote:
> On Sun, Oct 30, 2022 at 09:55:55AM +0200, Roi Dayan wrote:
> >
> >
> > On 26/10/2022 11:38, Simon Horman wrote:
> > > On Sun, Oct 23, 2022 at 09:27:10AM +0300, Roi Dayan wrote:
> > >> OVN is setting ct drop rule with a ct clear action.
> > >> OVS datapath behavior is if there is no forward action
> > >> the default is drop.
> > >> TC behavior is to continue with next match.
> > >> Fix to match tc to ovs behavior by setting last action
> > >> attribute as drop instead of pipe.
> > >
> > > This change looks good to me.
> > > And we will try to exercise it.
> > >
> > >> Also update lastused when parsing ct action.
> > >
> > > Could you split this into a separate patch?
> > > It seems like a distinct change.
> > >
> >
> > it's kind of related. now CT is last action so we update the stats.
> > we only use the stats on the last action. i.e. drop, fwd.
> > do you still want to separate?
>
> Thanks. I think I am fine with this the way it is.
> And will plan to apply this patch.
Thanks again, applied:
* 7a5ee32518df ("tc: On last action use drop action attribute instead of pipe")
https://github.com/openvswitch/ovs/commit/7a5ee32518df
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
