On 30 Nov 2022, at 20:50, Aaron Conole wrote:
> "Phelan, Michael" <[email protected]> writes:
>
>>> -----Original Message-----
>>> From: Finn, Emma <[email protected]>
>>> Sent: Wednesday 30 November 2022 14:15
>>> To: Eelco Chaudron <[email protected]>; Phelan, Michael
>>> <[email protected]>
>>> Cc: Ilya Maximets <[email protected]>; [email protected]; Van
>>> Haaren, Harry <[email protected]>; Stokes, Ian
>>> <[email protected]>
>>> Subject: RE: [ovs-dev] [v5] odp-execute: Add ISA implementation of
>>> set_masked IPv6 action
>> <snip>
>>>>>> I'm also wondering why CI didn't catch that...
>>>>>>
>>>>>> There might be 2 reasons:
>>>>>>
>>>>>> 1. Actions autovalidator is not enabled in CI, or 2. CI system
>>>>>> doesn't have avx512vbmi.
>>>>>>
>>>>>> Michael, could you check that?
>>>>>
>>>>> Hi Ilya,
>>>>> The CI system does have avx512vbmi, however, the actions
>>>>> autovalidator is
>>>> never enabled for any of the tests.
>>>>>
>>>>> I could add a test to configure with the actions autovalidator if
>>>>> you think
>>>> this would be a good value add for the CI?
>>>>
>>>> I would suggest doing a run with and without all the avx512 auto
>>>> validators enabled at compile time.
>>>>
>> Hi Eelco,
>> I believe make check-local is run through the GitHub Build and Test
>> job, Aaron you might correct me if I'm wrong on that.
>
> That job does run 'make check' and I think it is the same thing.
>
>> If this is the case then is there a need to do a check without AVX512
>> enabled on the Intel CI?
>
> I am not sure what the case is that isn't covered. Maybe Eelco has a
> thought?
I was referring to that you should build with the following configuration
options:
--enable-actions-default-autovalidator
--enable-autovalidator
--enable-mfex-default-autovalidator
And then on top of this run the following checks, which include datapaths, so
all AVX stuff gets tested:
make check
make check-kernel
make check-system-userspace
make check-afxdp
Also include re-runs of failed tests to avoid false positives.
Cheers,
Eelco
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
