> -----Original Message----- > From: Eelco Chaudron <[email protected]> > Sent: Thursday 1 December 2022 08:23 > To: Aaron Conole <[email protected]> > Cc: Phelan, Michael <[email protected]>; Finn, Emma > <[email protected]>; Ilya Maximets <[email protected]>; > [email protected]; Van Haaren, Harry <[email protected]>; > Stokes, Ian <[email protected]> > Subject: Re: [ovs-dev] [v5] odp-execute: Add ISA implementation of set_masked > IPv6 action > > > > On 30 Nov 2022, at 20:50, Aaron Conole wrote: > > > "Phelan, Michael" <[email protected]> writes: > > > >>> -----Original Message----- > >>> From: Finn, Emma <[email protected]> > >>> Sent: Wednesday 30 November 2022 14:15 > >>> To: Eelco Chaudron <[email protected]>; Phelan, Michael > >>> <[email protected]> > >>> Cc: Ilya Maximets <[email protected]>; [email protected]; Van > >>> Haaren, Harry <[email protected]>; Stokes, Ian > >>> <[email protected]> > >>> Subject: RE: [ovs-dev] [v5] odp-execute: Add ISA implementation of > >>> set_masked IPv6 action > >> <snip> > >>>>>> I'm also wondering why CI didn't catch that... > >>>>>> > >>>>>> There might be 2 reasons: > >>>>>> > >>>>>> 1. Actions autovalidator is not enabled in CI, or 2. CI system > >>>>>> doesn't have avx512vbmi. > >>>>>> > >>>>>> Michael, could you check that? > >>>>> > >>>>> Hi Ilya, > >>>>> The CI system does have avx512vbmi, however, the actions > >>>>> autovalidator is > >>>> never enabled for any of the tests. > >>>>> > >>>>> I could add a test to configure with the actions autovalidator if > >>>>> you think > >>>> this would be a good value add for the CI? > >>>> > >>>> I would suggest doing a run with and without all the avx512 auto > >>>> validators enabled at compile time. > >>>> > >> Hi Eelco, > >> I believe make check-local is run through the GitHub Build and Test > >> job, Aaron you might correct me if I'm wrong on that. > > > > That job does run 'make check' and I think it is the same thing. > > > >> If this is the case then is there a need to do a check without AVX512 > >> enabled > on the Intel CI? > > > > I am not sure what the case is that isn't covered. Maybe Eelco has a > > thought? > > I was referring to that you should build with the following configuration > options: > > --enable-actions-default-autovalidator > --enable-autovalidator > --enable-mfex-default-autovalidator > > And then on top of this run the following checks, which include datapaths, so > all > AVX stuff gets tested: > > make check > make check-kernel > make check-system-userspace > make check-afxdp > > Also include re-runs of failed tests to avoid false positives. Sure, I can add make check to the list of tests run on the CI. Make check-system-userspace is already tested on all patches. I'll also add the recheck flag so that we avoid any false positives.
I don't think make check-kernel or make check-afxdp are affected by AVX512 implementations but I may be wrong so feel free to correct me on that. If that is the case then I think they should be tested somewhere else. I have also added a new job to test the actions autovalidator in the same way as DPCLS, DPIF and MFEX. Thanks, Michael. > > Cheers, > > Eelco > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
