> > > > On 12/5/22 22:31, Ian Stokes wrote: > > > > > This commit add support to for DPDK v22.11.1, it includes the > > > > > following changes. > > > > > > > > > > 1. ci: Reduce DPDK compilation time. > > > > > 2. system-dpdk: Update vhost tests to be compatible with DPDK 22.07. > > > > > > > > > > > > > > > http://patchwork.ozlabs.org/project/openvswitch/list/?series=31652 > > > > > 8 > > > > > > > > > > 3. system-dpdk: Update vhost tests to be compatible with DPDK 22.07. > > > > > > > > > > > > > > > http://patchwork.ozlabs.org/project/openvswitch/list/?series=31133 > > > > > 2 > > > > > > > > > > 4. netdev-dpdk: Report device bus specific information. > > > > > 5. netdev-dpdk: Drop reference to Rx header split. > > > > > > > > > > > > > > > http://patchwork.ozlabs.org/project/openvswitch/list/?series=32180 > > > > > 8 > > > > > > > > > > In addition documentation was also updated in this commit for use > > > > > with DPDK v22.11.1. > > > > > > > > > > The Debian shared DPDK compilation test is removed as part of this > > > > > patch due to a packaging requirement. Once DPDK v22.11.1 is > > > > > available in Debian repositories it should be re-enabled in OVS. > > > > > > > > > > For credit all authors of the original commits to 'dpdk-latest' > > > > > with the above changes have been added as co-authors for this > > > > > commit > > > > > > > > > > Signed-off-by: David Marchand <david.march...@redhat.com> > > > > > Co-authored-by: David Marchand <david.march...@redhat.com> > > > > > Signed-off-by: Sunil Pai G <sunil.pa...@intel.com> > > > > > Co-authored-by: Sunil Pai G <sunil.pa...@intel.com> > > > > > Signed-off-by: Ian Stokes <ian.sto...@intel.com> > > > > > > > > > > --- > > > > > v3 -> v4 > > > > > * Rebase to master. > > > > > * Update to use DPDK v22.11.1 > > > > > * Update missed documentation mentioned by David. > > > > > * Remove Debian shared DPDK test in test matrix. > > > > > > > > > > v2 -> v3 > > > > > * Remove RFC status. > > > > > * Update debian control to use 22.11. > > > > > > > > > > v1 -> v2 > > > > > * Updated to use DPDK 22.11 rc4. > > > > > > > > > > * Please Note: Although DPDK documentation has been updated in > > > > > this patch the resource has not been updated on the DPDK site as > > > > > of yet, this will be expected as part of DPDK 22.11 final release. > > > > > > > > > > * The GitHub actions 'linux deb shared dpdk' is expected to fail > > > > > with this patch as DPDK 22.11 is not part of the package structure > > > > > yet. > > > > > --- > > > > > .ci/linux-build.sh | 7 ++- > > > > > .github/workflows/build-and-test.yml | 1 - > > > > > Documentation/faq/releases.rst | 2 +- > > > > > Documentation/intro/install/dpdk.rst | 16 +++---- > > > > > Documentation/topics/dpdk/phy.rst | 8 ++-- > > > > > Documentation/topics/dpdk/vdev.rst | 2 +- > > > > > Documentation/topics/dpdk/vhost-user.rst | 2 +- > > > > > Documentation/topics/testing.rst | 2 +- > > > > > Documentation/topics/userspace-tso.rst | 2 +- > > > > > NEWS | 18 +------- > > > > > debian/control.in | 2 +- > > > > > lib/netdev-dpdk.c | 24 ++++------ > > > > > rhel/openvswitch-fedora.spec.in | 2 +- > > > > > tests/system-dpdk.at | 78 > > > > > ++++++++++++++++---------------- > > > > > 14 files changed, 73 insertions(+), 93 deletions(-) > > > > > > > > > > > > > I'll leave the actual review to David and others, but at the glance > > > > the change looks fine. > > > > > > > > There is some problem with Intel CI, it looks like it is trying to > > > > apply the patch on outdated tree, hence the conflict in NEWS even > > > > though NEWS didn't change since the last week. > > > > Michael, could you check? > > > > > > I spotted this as well and flagged to Michael, looks like the Intel > > > CI branch was out of date but once updated it applied and Michael is re- > > running the tests now. > > > > Thanks Ian, I've reran all jobs now and they all passed. > > > > Also ran some additional tests on my own machine without issue. > > > > Tested-by: Michael Phelan <michael.phe...@intel.com> > > > > Thanks, > > Michael. > > I've ran some tests locally and everything looks good to me. > > Tested-by: Emma Finn <emma.f...@intel.com> > > Thanks, > Emma
Thanks all for the contributions to this, I've addressed the remaining issues related to NEWS indentation and pushed to master. Thanks Ian > > > > > > > > > > > > One small nit below. > > > > > > > > > Enabling TSO > > > > > ~~~~~~~~~~~~ > > > > > diff --git a/NEWS b/NEWS > > > > > index f6caf1ca7..0859f4335 100644 > > > > > --- a/NEWS > > > > > +++ b/NEWS > > > > > @@ -9,23 +9,7 @@ Post-v3.0.0 > > > > > - Windows: > > > > > * Conntrack IPv6 fragment support. > > > > > - DPDK: > > > > > - * OVS validated with DPDK 21.11.2. > > > > > - DPDK 21.11.2 contains fixes for the following CVEs: > > > > > - CVE-2022-28199 cve.mitre.org/cgi-bin/cvename.cgi?name=CVE- > 2022- > > > > 28199 > > > > > - CVE-2022-2132 cve.mitre.org/cgi-bin/cvename.cgi?name=CVE- > 2022- > > > > 2132 > > > > > - A bug was introduced in DPDK 21.11.1 by the commit > > > > > - 01e3dee29c02 ("vhost: fix unsafe vring addresses > > > > > modifications"). > > > > > - This bug can cause a deadlock when vIOMMU is enabled and NUMA > > > > > - reallocation of the virtqueues happen. > > > > > - A fix has been posted and pushed to the DPDK 21.11 branch. > > > > > - It can be found here: > > > > > - > > > https://patches.dpdk.org/project/dpdk/patch/20220725203206.427083- > > > > 2-david.march...@redhat.com/. > > > > > - If a user wishes to avoid the issue then it is recommended to > > > > > use > > > > > - DPDK 21.11.0 until the release of DPDK 21.11.3. > > > > > - It should be noted that DPDK 21.11.0 does not benefit from the > > > numerous > > > > > - bug and CVE fixes addressed since its release. > > > > > - If a user wishes to benefit from these fixes it is > > > > > recommended to use > > > > > - DPDK 21.11.2. > > > > > + * Add support for DPDK 22.11.1. > > > > > > > > This line is slightly overindented. Should be shifted 2 spaces to the > > > > left. > > > > Can be fixed while applying the change, I guess. > > > > > > Ah good catch, will fix before applying. > > > > > > Thanks > > > Ian > > > > > > > > > > > > - For the QoS max-rate and STP/RSTP path-cost configuration > > > > > OVS now > > > > assumes > > > > > 10 Gbps link speed by default in case the actual link speed > > > > > cannot be > > > > > determined. Previously it was 10 Mbps. Values can still be > > > > > overridden > > > > _______________________________________________ > > dev mailing list > > d...@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev