On 2 Mar 2023, at 7:34, Nobuhiro MIKI wrote:
> Fixed the manual page to indicate that both IPv4/IPv6
> are supported. Also added missing pkt_mark on one side
> and fixed the "gw" and "bridge" notation quirks.
>
> Reviewed-by: Simon Horman <[email protected]>
> Signed-off-by: Nobuhiro MIKI <[email protected]>
> ---
> lib/ovs-router.c | 4 ++--
> ofproto/ofproto-tnl-unixctl.man | 8 ++++----
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/lib/ovs-router.c b/lib/ovs-router.c
> index b5ac1edb6c65..a47c2b9bd3fd 100644
> --- a/lib/ovs-router.c
> +++ b/lib/ovs-router.c
> @@ -537,12 +537,12 @@ ovs_router_init(void)
> fatal_signal_add_hook(ovs_router_flush_handler, NULL, NULL, true);
> classifier_init(&cls, NULL);
> unixctl_command_register("ovs/route/add",
> - "ip_addr/prefix_len out_br_name [gw] "
> + "ip/plen output_bridge [gw] "
> "[pkt_mark=mark]",
> 2, 4, ovs_router_add, NULL);
> unixctl_command_register("ovs/route/show", "", 0, 0,
> ovs_router_show, NULL);
> - unixctl_command_register("ovs/route/del", "ip_addr/prefix_len "
> + unixctl_command_register("ovs/route/del", "ip/plen "
You are changing the text here, but the error messages you updated in the
previous patch still have the old names.
> "[pkt_mark=mark]", 1, 2, ovs_router_del,
> NULL);
> unixctl_command_register("ovs/route/lookup", "ip_addr "
> diff --git a/ofproto/ofproto-tnl-unixctl.man b/ofproto/ofproto-tnl-unixctl.man
> index 13a465119a90..6ed7e7fcea9b 100644
> --- a/ofproto/ofproto-tnl-unixctl.man
> +++ b/ofproto/ofproto-tnl-unixctl.man
> @@ -1,8 +1,8 @@
> .SS "OPENVSWITCH TUNNELING COMMANDS"
> These commands query and modify OVS tunnel components.
> .
> -.IP "\fBovs/route/add ipv4_address/plen output_bridge [GW]\fR"
> -Adds ipv4_address/plen route to vswitchd routing table. output_bridge
> +.IP "\fBovs/route/add ip/plen output_bridge [gw] [pkt_mark=mark]\fR"
> +Adds ip/plen route to vswitchd routing table. output_bridge
> needs to be OVS bridge name. This command is useful if OVS cached
> routes does not look right.
> .
> @@ -10,8 +10,8 @@ routes does not look right.
> Print all routes in OVS routing table, This includes routes cached
> from system routing table and user configured routes.
> .
> -.IP "\fBovs/route/del ipv4_address/plen\fR"
> -Delete ipv4_address/plen route from OVS routing table.
> +.IP "\fBovs/route/del ip/plen [pkt_mark=mark]\fR"
> +Delete ip/plen route from OVS routing table.
> .
> .IP "\fBtnl/neigh/show\fR"
> .IP "\fBtnl/arp/show\fR"
> --
> 2.31.1
>
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
