On 2023/03/03 19:01, Eelco Chaudron wrote: > > > On 2 Mar 2023, at 7:34, Nobuhiro MIKI wrote: > >> Fixed the manual page to indicate that both IPv4/IPv6 >> are supported. Also added missing pkt_mark on one side >> and fixed the "gw" and "bridge" notation quirks. >> >> Reviewed-by: Simon Horman <[email protected]> >> Signed-off-by: Nobuhiro MIKI <[email protected]> >> --- >> lib/ovs-router.c | 4 ++-- >> ofproto/ofproto-tnl-unixctl.man | 8 ++++---- >> 2 files changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/lib/ovs-router.c b/lib/ovs-router.c >> index b5ac1edb6c65..a47c2b9bd3fd 100644 >> --- a/lib/ovs-router.c >> +++ b/lib/ovs-router.c >> @@ -537,12 +537,12 @@ ovs_router_init(void) >> fatal_signal_add_hook(ovs_router_flush_handler, NULL, NULL, true); >> classifier_init(&cls, NULL); >> unixctl_command_register("ovs/route/add", >> - "ip_addr/prefix_len out_br_name [gw] " >> + "ip/plen output_bridge [gw] " >> "[pkt_mark=mark]", >> 2, 4, ovs_router_add, NULL); >> unixctl_command_register("ovs/route/show", "", 0, 0, >> ovs_router_show, NULL); >> - unixctl_command_register("ovs/route/del", "ip_addr/prefix_len " >> + unixctl_command_register("ovs/route/del", "ip/plen " > > You are changing the text here, but the error messages you updated in the > previous patch still have the old names.
Thanks for your review. Sorry for trivial mistakes. I have submitted v7 patch set. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
