On 15/03/2023 11:00, Simon Horman wrote:
On Mon, Mar 13, 2023 at 12:27:51PM +0200, Roi Dayan wrote:From: Oz Shlomo <[email protected]> Currently jumping over a output-to-port action is translated to tc mirror action and stolen control action. However, the tc control action is not propagated to the hw offload action, thus the hardware action will mirror the packet and continue to the next action. Transalte mirror/stolen to "mirred egress redirect" action which terminates the action list. Fixes: e4daf88a4390 ("netdev-offload-tc: Handle check_pkt_len datapath action.") Signed-off-by: Oz Shlomo <[email protected]> Reviewed-by: Roi Dayan <[email protected]>Perhaps I messed something up, but I am seeing a lot of failed check-offloads tests [1] with this patch applied on top of Eelco's patches to add those tests to the GitHub workflow [2].
Thanks Simon, We will check this patch again in our lab
[1] https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhorms%2Fovs%2Factions%2Fruns%2F4415894043%2Fjobs%2F7741856452&data=05%7C01%7Cozsh%40nvidia.com%7C07c987cf05514686c62b08db2533cd3a%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C638144676641214551%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VKe3N4zZAXxlZrVwfmneLB5fN0vJxlAuwQKIp4RqwIo%3D&reserved=0 [2] [PATCH v3 2/2] ci: Run tc offload tests in GitHub Actions. https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fpipermail%2Fovs-dev%2F2023-March%2F402672.html&data=05%7C01%7Cozsh%40nvidia.com%7C07c987cf05514686c62b08db2533cd3a%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C638144676641214551%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=JjH%2Bfay7I9kSOlJefXWjboA%2FFRGRWy6TB5kq1BOaFgc%3D&reserved=0
_______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
