On 3/15/23 11:51, Simon Horman wrote: > On Wed, Mar 15, 2023 at 11:52:16AM +0200, Oz Shlomo wrote: >> >> On 15/03/2023 11:00, Simon Horman wrote: >>> On Mon, Mar 13, 2023 at 12:27:51PM +0200, Roi Dayan wrote: >>>> From: Oz Shlomo <[email protected]> >>>> >>>> Currently jumping over a output-to-port action is translated to tc >>>> mirror action and stolen control action. >>>> However, the tc control action is not propagated to the hw offload action, >>>> thus the hardware action will mirror the packet and continue to the next >>>> action. >>>> >>>> Transalte mirror/stolen to "mirred egress redirect" action which terminates >>>> the action list. >>>> >>>> Fixes: e4daf88a4390 ("netdev-offload-tc: Handle check_pkt_len datapath >>>> action.") >>>> Signed-off-by: Oz Shlomo <[email protected]> >>>> Reviewed-by: Roi Dayan <[email protected]> >>> Perhaps I messed something up, but I am seeing a lot of failed >>> check-offloads tests [1] with this patch applied on top of >>> Eelco's patches to add those tests to the GitHub workflow [2]. >> >> Thanks Simon, >> >> We will check this patch again in our lab > > Thanks Oz, much appreciated.
I see a lot of failures as well. They are caused by 'Kernel flower acknowledgment does not match request!' message. And that doesn't sound good. The system is Ubuntu 22.10 in my case. I'm marking this patch as 'Changes Requested' for now. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
