Hi Frode,
Thanks for fixing this, just had one nit below since you're pushing out
a new PS.
On 5/10/23 11:12 AM, Frode Nordahl wrote:
The tc module combines the use of the `tc_transact` helper
function for communication with the in-kernel tc infrastructure
with assertions on the reply data by `ofpbuf_at_assert` on the
received data prior to further processing.
<snip>
--- a/lib/netlink-socket.c
+++ b/lib/netlink-socket.c
@@ -1798,6 +1798,11 @@ nl_pool_release(struct nl_sock *sock)
*
* 2. Resending the request causes it to be re-executed, so the request
* needs to be idempotent.
+ *
+ * 3. In the event that the kernel is to busy to handle the request to
+ * receive the response (i.e. EAGAIN), this function will still return
+ * 0. The caller can check for this condition by checking for a zero
+ * size of the 'replyp' ofpbuf buffer.
s/to busy/too busy
-Brian
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
