On Mon, Jun 26, 2023 at 10:57 PM Simon Horman <simon.hor...@corigine.com> wrote:
>
> On Fri, Oct 09, 2020 at 08:15:03PM +0800, hepeng.0320 wrote:
> > when running ovs-tcpdump -i ethX and the port is used as the incomming port 
> > for a vxlan port.
> >
> > The callstack for the upcall:
> >
> > mirror_ingress_packet
> > mirror_packet
> > output_normal
> > compose_output_action
> > compose_output_action__
> > terminate_native_tunnel
> >
> > will xlate the action into a tnl_pop action, not an output action to the
> > mirror port. So eventually the translated actions will be 'tnl_pop(x), 
> > tnl_pop(x)'.
> > However, the right action should be '(mirror port), tnl_pop(x)'
> >
> > This patch adds a flag in xlate_ctx indicating the current output_normal
> > is used by mirroring. Note that we cannot use ctx->mirrors as the
> > indicator as in the mirror code, the ctx->mirrors will not be cleared
> > after mirror action finished.
> >
> > Signed-off-by: hepeng.0320 <hepeng.0...@bytedance.com>
>
> Hi all,
>
> this patch appears to have gone stale - no response in the best part of
> three years.
>
> Accordingly, I am marking it as Changes Requested in patchwork
> (I'm still searching for the best status for such cases).

IIRC, there is another patch which has already been merged. It solves
the same problem through another approach.
Although I am not sure its approach works in every situation, the
problem stated in the comments should have
been solved.

I think you can drop the patch.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to