On 9/19/23 13:27, Eelco Chaudron wrote:
> 
> 
> On 19 Sep 2023, at 10:42, Robin Jarry wrote:
> 
>> Adrian Moreno, Sep 19, 2023 at 09:18:
>>>> Both OVSDB and appctl are literally JSON-RPC protocols.  There is no
>>>> need to re-invent anything.
>>>
>>> Right. Isn't appctl simpler in this case? IIUC, it would still satisfy
>>> the requirements: client decides update interval, flexible schema, etc
>>> with the benefits of incurring in less cost (no ovs-vswithcd <-> ovsdb
>>> communication, no need to store data in both places) and probably
>>> involving less internal code change.
>>>
>>> Just to clarify: I'm referring to allowing JSON output of the (already
>>> JSON-RPC) appctl protocol.
>>
>> I agree. Using ovsdb for ephemeral stats seems weird to me. appctl and

OVSDB already contains a lot of ephemeral stats.

>> a more fluid schema/data structure would be suitable.
>>
>> What kind of API did you have in mind to structure the JSON output?
> 
> I guess we should use the appctl json API. I’m including Jakob who is going 
> to come up with a POC to see if we can add json support for the existing 
> appctl command. Probably starting with the “dpif-netdev/pmd-perf-show” 
> output, but I let him comment.

With flexibility of appctl comes absolutely no guarantee for API
stability.  But as soon as we have structured output, someone will
expect it.  If we can agree that users cannot rely on the structure
of that structured output, then it's fine.  Otherwise, OVSDB with
its defined schema is a much better choice, IMO.  Constructing a
single 'select' transaction for OVSDB isn't really much more
difficult than constructing an appctl JSON-PRC request.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to