On Tue, Oct 03, 2023 at 01:51:34PM +0300, Roi Dayan wrote:
>
> On 03/10/2023 13:36, Simon Horman wrote:
> > On Tue, Oct 03, 2023 at 11:33:04AM +0300, Roi Dayan via dev wrote:
> >> The cited commit fixed missing mirror packets by reset mirror when
> >> packets are modified but setting geneve options was also treated as
> >> a modified packet but should be treated as a part of set_tunnel
> >> which doesn't reset mirror.
> >>
> >> Fixes: 1437f51fea92 ("ofproto-dpif-upcall: Mirror packets that are
> >> modified.")
> >
> > Hi Roi,
> >
> > I don't think that hash appears in the master branch.
> > Perhaps the tag should be:
> >
> > Fixes: feed7f677505 ("ofproto-dpif-upcall: Mirror packets that are
> > modified.")
>
> right. thanks.
> I got it by mistake from development branch I had instead of from master.
> The correct hash is what you specified.
> Do I need to push v2 to change this or it can modified when the patch will be
> taken?
Thanks,
I don't think a v2 is necessary just because of this.
> >> Signed-off-by: Roi Dayan <[email protected]>
> >
> > The above notwithstanding, this looks good to me.
> >
> > Acked-by: Simon Horman <[email protected]>
>
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
