On 03/10/2023 15:22, Ilya Maximets wrote:
> On 10/3/23 10:33, Roi Dayan wrote:
>> The cited commit fixed missing mirror packets by reset mirror when
>> packets are modified but setting geneve options was also treated as
>> a modified packet but should be treated as a part of set_tunnel
>> which doesn't reset mirror.
>>
>> Fixes: 1437f51fea92 ("ofproto-dpif-upcall: Mirror packets that are
>> modified.")
>> Signed-off-by: Roi Dayan <[email protected]>
>> ---
>> ofproto/ofproto-dpif-xlate.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
>> index be4bd6657688..e243773307b7 100644
>> --- a/ofproto/ofproto-dpif-xlate.c
>> +++ b/ofproto/ofproto-dpif-xlate.c
>> @@ -7097,7 +7097,7 @@ reset_mirror_ctx(struct xlate_ctx *ctx, const struct
>> flow *flow,
>>
>> set_field = ofpact_get_SET_FIELD(a);
>> mf = set_field->field;
>> - if (mf_are_prereqs_ok(mf, flow, NULL)) {
>> + if (mf_are_prereqs_ok(mf, flow, NULL) && !mf_is_tun_metadata(mf)) {
>> ctx->mirrors = 0;
>> }
>> return;
>
>
> Hi, Roi. Thanks for the fix!
>
> Could you, please, add a unit test for it?
> Something similar to the mirroring tests we have in tests/ofproto-dpif.at
> should be fine.
>
> Best regards, Ilya Maximets.
Hi,
I sent a test in new patch '[PATCH 1/1] tests/tunnel.at: Add geneve options
mirror test'
Thanks,
Roi
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
