On Wed, Oct 04, 2023 at 10:16:49AM +0200, Simon Horman wrote: > On Tue, Oct 03, 2023 at 04:10:47PM +0400, Viacheslav Galaktionov wrote: > > On 9/29/23 17:02, Simon Horman wrote: > > > On Mon, Sep 04, 2023 at 07:45:07PM +0400, Viacheslav Galaktionov via dev > > > wrote: > > > > Currently, if the user wants to track related connections, they have to > > > > specify a helper in all CT actions, which contradicts the behaviour > > > > described in the documentation. > > > > > > > > Fix this by using the helper committed along with the connection > > > > whenever > > > > a given CT action does not specify a helper of its own. > > > > > > > > Signed-off-by: Viacheslav Galaktionov > > > > <[email protected]> > > > > Acked-by: Ivan Malov <[email protected]> > > > Hi Viacheslav, > > > > > > thanks for your patch-set. I agree this is a problem that ought to be > > > fixed. > > Hi Simon! > > > > Thanks for the feedback, much appreciated! > > > > > > Some feedback on the patchset from my side: > > > > > > 1. The test added by patch 1/2 fails without patch 2/2. > > > I think it would be good to reverse the order of the patches in the > > > series. > > Thanks, I'll reverse the order of patches on my next submit. My original > > logic was to "introduce" the problem by making it visible and then "fix" > > it, but I suppose having tests fail is not ideal after all. > > > 2. With this series applied the following check-system-userspace tests > > > seem to fail. (I only checked with TESTSUITEFLAGS="-k conntrack" so > > > far.) > > > > > > 149: conntrack - IPv6 FTP with SNAT FAILED > > > (system-traffic.at:7119) > > > 150: conntrack - IPv6 FTP Passive with SNAT FAILED > > > (system-traffic.at:7180) > > > 151: conntrack - IPv6 FTP with SNAT - orig tuple FAILED > > > (system-traffic.at:7240) > > > > > > In each case the critical part of the test log seems to be something > > > like (this is for test #151): > > > > > > ./system-traffic.at:7240: ip netns exec at_ns0 sh << NS_EXEC_HEREDOC > > > wget ftp://[fc00::2] -6 --no-passive-ftp -t 3 -T 1 > > > --retry-connrefused -v --serv > > > er-response --no-remove-listing -o wget0.log -d > > > NS_EXEC_HEREDOC > > > [I 2023-09-29 13:00:21] fc00::240:43342-[] FTP session opened > > > (connect) > > > [I 2023-09-29 13:00:21] fc00::240:43342-[anonymous] USER 'anonymous' > > > logged in. > > > [I 2023-09-29 13:00:22] fc00::240:43342-[anonymous] FTP session > > > closed (disconne > > > ct). > > > [I 2023-09-29 13:00:23] fc00::240:43344-[] FTP session opened > > > (connect) > > > [I 2023-09-29 13:00:23] fc00::240:43344-[anonymous] USER 'anonymous' > > > logged in. > > > [I 2023-09-29 13:00:24] fc00::240:43344-[anonymous] FTP session > > > closed (disconne > > > ct). > > > [I 2023-09-29 13:00:26] fc00::240:52606-[] FTP session opened > > > (connect) > > > [I 2023-09-29 13:00:26] fc00::240:52606-[anonymous] USER 'anonymous' > > > logged in. > > > [I 2023-09-29 13:00:27] fc00::240:52606-[anonymous] FTP session > > > closed (disconne > > > ct). > > > ./system-traffic.at:7240: exit code was 4, expected 0 > > And what about without this series? These tests seem to fail for me even > > without my patches, along with these ones: > > > > 118: conntrack - FTP over IPv6 FAILED > > (system-traffic.at:5426) > > 119: conntrack - IPv6 FTP Passive FAILED > > (system-traffic.at:5485) > > > > I'm using the current master branch (commit hash 13dde11). My patches > > don't affect these tests, just add a new one that passes. > > My testing indicated that they do not fail without this patch-set. > But I'll check again.
Hi, I ran make check-system-userspace TESTSUITEFLAGS='-k conntrack' against 13dde11 on both RHEL 9.2 and Ubuntu 23.04 and the result was that all tests passed (other than those skipped), including 118 and 119. But with this patch applied, tests 149, 150 and 151 failed. ... _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
