On 06.10.23 11:17, Eelco Chaudron wrote:
>
> On 6 Oct 2023, at 11:10, Jakob Meng wrote:
>
>     On 06.10.23 10:55, Eelco Chaudron wrote:
>>     On 6 Oct 2023, at 9:21, Jakob Meng wrote:
>>
>>>     On 05.10.23 17:53, Kevin Traynor wrote:
>>>>     On 05/10/2023 13:52, Eelco Chaudron wrote:
>>>>>     On 4 Oct 2023, at 10:31, [email protected] wrote:
>>>>>
>>>>>>     From: Jakob Meng <[email protected]>
>>>>>>
>>>>>>     The status options pci-vendor_id and pci-device_id for dpdk netdevs
>>>>>>     have been replaced by bus_info. This patch updates the documentation
>>>>>>     in vswitchd/vswitch.xml accordingly.
>>>>>>
>>>>>>     Fixes: a77c7796f23a ("dpdk: Update to use v22.11.1.")
>>>>>     Thanks for fixing the documentation, however I think the commit 
>>>>> message should somehow state this is related to the documentation.
>>>>>
>>>>     Message it probably ok, but yeah title might mislead so should mention 
>>>> docs.
>>     I meant the subject of the commit message ;)
>>
>>>     Maybe "netdev-dpdk: Update docs for interface info in 
>>> vswitchd/vswitch.xml."?
>>     This looks good to me! Maybe send a new rev with this subject fixed and 
>> the added sign-off, and add my ACKs.
>>
>>     Then Kevin, if you want, you can try to merge them.
>     Thank you, done ☺️
>
>     Patch v2: 
> https://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/
>
>
> One request, can you sent a v3 with for the whole series? If you make a 
> change to a patch in a series, you should re-sent the entire series, 
> including any ACKs added (or removed, if you made changes). This way we only 
> need to track the latest version of the series, rather than each patch 
> individually.
>

Done, v3 series:

https://patchwork.ozlabs.org/project/openvswitch/list/?series=376419
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to