On 06/10/2023 09:55, Eelco Chaudron wrote:


On 6 Oct 2023, at 9:21, Jakob Meng wrote:

On 05.10.23 17:53, Kevin Traynor wrote:
On 05/10/2023 13:52, Eelco Chaudron wrote:
On 4 Oct 2023, at 10:31, [email protected] wrote:

From: Jakob Meng <[email protected]>

The status options pci-vendor_id and pci-device_id for dpdk netdevs
have been replaced by bus_info. This patch updates the documentation
in vswitchd/vswitch.xml accordingly.

Fixes: a77c7796f23a ("dpdk: Update to use v22.11.1.")

Thanks for fixing the documentation, however I think the commit message should 
somehow state this is related to the documentation.


Message it probably ok, but yeah title might mislead so should mention docs.

I meant the subject of the commit message ;)

Maybe "netdev-dpdk: Update docs for interface info in vswitchd/vswitch.xml."?

This looks good to me! Maybe send a new rev with this subject fixed and the 
added sign-off, and add my ACKs.

Then Kevin, if you want, you can try to merge them.


ok, I'll take a look over v3 and apply, thanks.


Cheers,

Eelco


_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to