On Wed, Oct 18, 2023 at 10:46:10PM +0200, Ilya Maximets wrote: > Currently we log the 980-ish byte long tc_action structure as a > single long hex string. That is very hard to read and hard to > spot the difference between two. And most of the fields are zero. > > Use the sparse hex dump instead as we do for keys already. > > Ex.: > > Action 1 mismatch: > - Expected Action: > 00000000 f0 3c 00 00 01 00 00 00-00 00 00 00 00 00 00 00 > 000003d0 00 00 00 00 ff ff ff ff- > - Received Action: > 00000000 f0 3c 00 00 01 01 00 00-00 00 00 00 00 00 00 00 > 000003d0 00 00 00 00 ff ff ff ff- > > Without the change, each action would be a 1900+ characters > long string of mostly zeroes. > > Signed-off-by: Ilya Maximets <[email protected]>
Hi Ilya, I agree this is is a nice improvement. And I'm fine with it as is. But I do feel it is worth mentioning that when reading the patch I was surprised that it had no impact on test cases. Perhaps we could consider adding one at some point? In any case, Acked-by: Simon Horman <[email protected]> > --- > > We may want to backport this down to 2.17, since it's > a debug-only change. FWIIW, I am fine either way. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
