On 18 Oct 2023, at 22:46, Ilya Maximets wrote:
> Currently we log the 980-ish byte long tc_action structure as a
> single long hex string. That is very hard to read and hard to
> spot the difference between two. And most of the fields are zero.
>
> Use the sparse hex dump instead as we do for keys already.
>
> Ex.:
>
> Action 1 mismatch:
> - Expected Action:
> 00000000 f0 3c 00 00 01 00 00 00-00 00 00 00 00 00 00 00
> 000003d0 00 00 00 00 ff ff ff ff-
> - Received Action:
> 00000000 f0 3c 00 00 01 01 00 00-00 00 00 00 00 00 00 00
> 000003d0 00 00 00 00 ff ff ff ff-
>
> Without the change, each action would be a 1900+ characters
> long string of mostly zeroes.
>
> Signed-off-by: Ilya Maximets <[email protected]>
Changes look good to me!
Acked-by: Eelco Chaudron <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
