On 11/2/23 16:30, [email protected] wrote:
> From: Numan Siddique <[email protected]>
> 
> With the 'ubuntu-latest' image in github CI,  OVS compilation
> is failing with the below error:
> 
> ---
> python/ovs/tests/test_dns_resolve.py:272:54: E231 missing whitespace after ':'
> make[1]: *** [Makefile:6784: flake8-check] Error 1
> ---

The robot complained about:

"ERROR: Author Numan Siddique <[email protected]> needs to sign off."

And that's because of the sets of "---" above.  They confuse "git am".
With those removed:

Acked-by: Dumitru Ceara <[email protected]>

Unrelated, but we setup python 3.9 for the build-dpdk and build osx
jobs.  Would it make sense to aligned all of them on Python 3.11?

Thanks,
Dumitru

> 
> Python 3.12 and flake8 version used seems to have some issues.
> 
> Fallback to Python 3.11 as a temporary fix.
> Suggested-by: Ilya Maximets <[email protected]>
> Signed-off-by: Numan Siddique <[email protected]>
> ---
>  .github/workflows/ovn-fake-multinode-tests.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.github/workflows/ovn-fake-multinode-tests.yml 
> b/.github/workflows/ovn-fake-multinode-tests.yml
> index 9a5cd83a65..aa55a1e3f5 100644
> --- a/.github/workflows/ovn-fake-multinode-tests.yml
> +++ b/.github/workflows/ovn-fake-multinode-tests.yml
> @@ -158,7 +158,7 @@ jobs:
>      - name: set up python
>        uses: actions/setup-python@v4
>        with:
> -        python-version: '3.x'
> +        python-version: '3.11'
>  
>      - name: Check out ovn
>        uses: actions/checkout@v3

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to