On 11/7/23 22:33, Mark Michelson wrote: > On 11/6/23 23:47, Dumitru Ceara wrote: >> On 11/2/23 16:30, [email protected] wrote: >>> From: Numan Siddique <[email protected]> >>> >>> With the 'ubuntu-latest' image in github CI, OVS compilation >>> is failing with the below error: >>> >>> --- >>> python/ovs/tests/test_dns_resolve.py:272:54: E231 missing whitespace after >>> ':' >>> make[1]: *** [Makefile:6784: flake8-check] Error 1 >>> --- >> >> The robot complained about: >> >> "ERROR: Author Numan Siddique <[email protected]> needs to sign off." >> >> And that's because of the sets of "---" above. They confuse "git am". >> With those removed: >> >> Acked-by: Dumitru Ceara <[email protected]> >> >> Unrelated, but we setup python 3.9 for the build-dpdk and build osx >> jobs. Would it make sense to aligned all of them on Python 3.11? > > It makes sense to pin to a specific version of python to prevent the > sort of errors this patch is trying to avoid. I think we should align > all of them on the same version. However, whether we use 3.9 or 3.11 is > not that important IMO since we don't use any features specific to 3.10 > or 3.11.
FWIW, this pinning to python 3.9 came from incompatibility of a version of a meson we used to build DPDK with with newer versions of python. We did move to a newer version of meson last year though, but this python version restriction wasn't re-evaluated. David, do you know if the python version is still a problem? Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
