Hello Eelco,
On Mon, Nov 27, 2023 at 1:39 PM Eelco Chaudron <echau...@redhat.com> wrote:
>
> When new drivers are introduced, the cache key is not accurately computed.
> Previously, the dpdk build process was integrated into the main Linux
> build script, where specific lines were employed to generate the key.
> Since it is now separated into two distinct files, this patch will
> compute the key based on the content of these two files.
I would rephrase this last sentence, as "two distinct files" and
"these two files" are a bit unclear.
Afaiu, the former refers to .ci/{linux,dpdk}-build.sh, while the
latter refers to .ci/dpdk-{setup,build}.sh
Otherwise the fix lgtm.
>
> Fixes: 4e90baca89f0 ("system-dpdk: Run traffic tests.")
> Signed-off-by: Eelco Chaudron <echau...@redhat.com>
> ---
> .github/workflows/build-and-test.yml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.github/workflows/build-and-test.yml
> b/.github/workflows/build-and-test.yml
> index d74668f61..e9a2714fb 100644
> --- a/.github/workflows/build-and-test.yml
> +++ b/.github/workflows/build-and-test.yml
> @@ -30,7 +30,7 @@ jobs:
> # This also allows us to use cache from any branch as long as version
> # and a way we're building DPDK stays the same.
> run: |
> - grep -irE 'RTE_|DPDK|meson|ninja' .ci/dpdk-* > dpdk-ci-signature
> + cat .ci/dpdk-* > dpdk-ci-signature
> grep -rwE 'DPDK_GIT|DPDK_VER' .github/ >> dpdk-ci-signature
> if [ "${DPDK_VER##refs/*/}" != "${DPDK_VER}" ]; then
> git ls-remote --heads $DPDK_GIT $DPDK_VER >> dpdk-ci-signature
>
Reviewed-by: David Marchand <david.march...@redhat.com>
--
David Marchand
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
