On 11/27/23 13:41, Eelco Chaudron wrote: > I ran 80 series of full tests, and the following tests showed failures:
Hi, Eelco. It looks like this patch should go before enabling the actual testing. Some of the previous patches in the sat failed CI because of these issues. > > 802.1ad - vlan_limit > +2023-11-20T10:32:11.245Z|00001|dpif_netdev(revalidator5)|ERR|internal > error parsing flow key recirc_id(0),dp_hash(0),skb_priority(0), > in_port(2),skb_mark(0),ct_state(0),ct_zone(0),ct_mark(0),ct_label(0), > packet_type(ns=0,id=0),eth(src=42:7e:4b:46:68:1b,dst=33:33:ff:46:68:1b), > eth_type(0x88a8),vlan(vid=4094,pcp=0),encap(eth_type(0x8100), > vlan(vid=100,pcp=0),encap(eth_type(0x86dd),ipv6( > src=::,dst=ff02::1:ff46:681b,label=0,proto=58,tclass=0,hlimit=255, > frag=no),icmpv6(type=135,code=0),nd(target=fe80::407e:4bff:fe46:681b, > sll=00:00:00:00:00:00,tll=00:00:00:00:00:00))) > +2023-11-20T10:32:11.245Z|00002|dpif(revalidator5)|WARN|netdev@ovs-netdev: > failed to put[modify] (Invalid argument) > ufid:ef1ca90c-dbd0-4ca7-9869-411bdffd1ece recirc_id(0),dp_hash(0/0), > skb_priority(0/0),in_port(2),skb_mark(0/0),ct_state(0/0),ct_zone(0/0), > ct_mark(0/0),ct_label(0/0),packet_type(ns=0,id=0), > eth(src=42:7e:4b:46:68:1b,dst=33:33:ff:46:68:1b),eth_type(0x88a8), > vlan(vid=4094,pcp=0/0x0),encap(eth_type(0x8100), > vlan(vid=100/0x0,pcp=0/0x0),encap(eth_type(0x86dd), > ipv6(src=::/::,dst=ff02::1:ff46:681b/::,label=0/0,proto=58/0, > tclass=0/0,hlimit=255/0,frag=no),icmpv6(type=135/0,code=0/0), > nd(target=fe80::407e:4bff:fe46:681b/::, > sll=00:00:00:00:00:00/00:00:00:00:00:00, > tll=00:00:00:00:00:00/00:00:00:00:00:00))), actions:drop BTW, we should be able to fix this test now, since David fixed the revalidator pause/resume logic. > > conntrack - zones from other field, more tests > +2023-11-20T10:45:43.015Z|00001|dpif(handler5)|WARN|system@ovs-system: > execute ct(commit),3 failed (Invalid argument) on packet tcp, > vlan_tci=0x0000,dl_src=42:7e:4b:46:68:1b,dl_dst=ba:72:4c:a5:31:6b, > nw_src=10.1.1.1,nw_dst=10.1.1.2,nw_tos=0,nw_ecn=0,nw_ttl=64, > nw_frag=no,tp_src=53738,tp_dst=80,tcp_flags=psh|ack tcp_csum:e4a > > conntrack - limit by zone > ./system-traffic.at:5154: ovs-appctl dpctl/ct-get-limits zone=0,1,2,3,4,5 > --- - 2023-11-20 10:51:09.965375141 +0000 > +++ /home/runner/work/ovs/ovs/tests/system-kmod-testsuite.dir/at-groups/ > 114/stdout 2023-11-20 10:51:09.956723756 +0000 > @@ -1,5 +1,5 @@ > default limit=10 > -zone=0,limit=5,count=5 > +zone=0,limit=5,count=6 > > conntrack - Multiple ICMP traverse > ./system-traffic.at:7571: ovs-appctl dpctl/dump-conntrack | grep > "dst=10.1.1" | sed -e 's/port=[0-9]*/port=<cleared>/g' -e > 's/id=[0-9]*/id=<cleared>/g' > -e 's/state=[0-9_A-Z]*/state=<cleared>/g' | sort | uniq > --- - 2023-11-20 15:36:02.591051192 +0000 > +++ > /home/runner/work/ovs/ovs/tests/system-kmod-testsuite.dir/at-groups/156/stdout > 2023-11-20 15:36:02.585722099 +0000 Please, try to avoid such a long lines in the commit message. Some can be split, some can be trimmed as most of the info in them is not actually useful. I didn't fully review the actual code change here. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
