On 27 Nov 2023, at 13:58, Ilya Maximets wrote:
> On 11/27/23 13:38, Eelco Chaudron wrote: >> This set of patches incorporates the remaining make check tests into >> the GitHub action run. Notably, this inclusion does not appear to >> extend the overall run time, as the newly added tests complete prior >> to the existing ones. > > Hmm. This doesn't sound right. We do not have infinite parallelizm > in GHA and we already above the limit for parallel jobs. So, these > tests will most certainly increase the overall time. At least for > multiple workflows running at the same time, e.g. will slow down the > 0-day-bot or the patch backporting process. > > Not saying we shouldn't do this, just highlighting the potential issue. Perhaps I should have phrased it differently; when comparing the runs, they took an additional two minutes. I agree that it will probably increase the robot’s run time, but I think it’s worth the additional delay. > Best regards, Ilya Maximets. > >> >> V2: >> Added patch to fix DPDK cache key generation. >> >> Eelco Chaudron (9): >> ci: Add make check-ovsdb-cluster tests to GitHub action ci. >> ci: Add make check-kernel to GitHub actions ci. >> ci: Add make check-offloads to GitHub actions ci. >> ci: Add make check-system-userspace to GitHub actions ci. >> ci: Add make check-system-tso to GitHub actions ci. >> ci: Fix dpdk build cache key generation. >> ci: Allow make check-dpdk to run more tests. >> ci: Add make check-afxdp to GitHub actions ci. >> ci: Exclude tests that show random failures through GitHub actions. >> >> >> .ci/dpdk-build.sh | 2 +- >> .ci/linux-build.sh | 15 ++++++---- >> .github/workflows/build-and-test.yml | 41 +++++++++++++++++++++---- >> python/test_requirements.txt | 5 +++- >> tests/system-common-macros.at | 4 +++ >> tests/system-offloads-traffic.at | 2 ++ >> tests/system-traffic.at | 45 +++++++++++++++------------- >> 7 files changed, 81 insertions(+), 33 deletions(-) >> >> >> _______________________________________________ >> dev mailing list >> d...@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
