On 1/9/24 23:49, Ilya Maximets wrote: > Adding a --config-file option that will be used in the future to > allow users to provide the database server configuration via a > JSON file. > > For now, it does nothing useful, but we define it as mutually > exclusive with all the command line options and UnixCtl commands > that configure values that will be available via a config file. > This will ensure that we don't have too many ways of configuring > the same thing at the same time. > > New appctl command 'ovsdb-server/reload' is going to signal OVSDB > server that it needs to re-read the configuration file. > > While at it, adding a missing 'usage' line for '--no-dbs'. This > option is rarely used, so it doesn't seem to be worth a separate fix. > > Signed-off-by: Ilya Maximets <i.maxim...@ovn.org> > --- > ovsdb/ovsdb-server.c | 110 ++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 109 insertions(+), 1 deletion(-) > > diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c > index d7a823220..3765cf066 100644 > --- a/ovsdb/ovsdb-server.c > +++ b/ovsdb/ovsdb-server.c > @@ -95,6 +95,13 @@ static unixctl_cb_func > ovsdb_server_get_sync_exclude_tables; > static unixctl_cb_func ovsdb_server_get_sync_status; > static unixctl_cb_func ovsdb_server_get_db_storage_status; > > +/* Holds the name of the configuration file passed via --config-file. > + * Mutually exclusive with command-line and unixctl configuration > + * that can otherwise be done via configuration file. */ > +static char *config_file_path = NULL;
Nit: initialization of .bss variables is not required. Aside from that, looks good! Acked-by: Dumitru Ceara <dce...@redhat.com> _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
