On 1/9/24 23:49, Ilya Maximets wrote: > Just introduced structure 'jsonrpc_session_options' is the same > as part of the 'ovsdb_jsonrpc_options'. In fact, these options > do really belong to a lower layer. So, replace a copy of these > fields with a structure, so it can be easily passed to jsonrpc's > 'jsonrpc_session_set_options()'. > > Not creating separate JSON parsing/formatting functions to avoid > creating an extra nesting level for the users who will write > the JSON definition in a configuration file. I.e. keeping the > JSON object flat. Also, not changing the 'db_config->options' > to be 'jsonrpc_session_options', even though we don't need the > 'role' or 'read-only' fields. This allows us to use the same > JSON parsing function for both the remotes ans database sources. > Can be changed in the future, but for now keeping as is to avoid > extra code complication. > > Signed-off-by: Ilya Maximets <[email protected]> > ---
Looks good to me, thanks! Acked-by: Dumitru Ceara <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
