On 1/11/24 16:29, [email protected] wrote:
> From: Numan Siddique <[email protected]>
> 
> This new engine now maintains the load balancer and NAT data of a
> logical router which was earlier part of northd engine node data.
> The main inputs to this engine are:
>    - northd node
>    - lr_nat node
>    - lb_data node
> 
> A record for each logical router is maintained in the 'lr_stateful_table'
> hmap table and this record
>    - stores the lb related data
>    - embeds the 'lr_nat' record.
> 
> This engine node becomes an input to 'lflow' node.
> 
> Signed-off-by: Numan Siddique <[email protected]>
> ---

Hi Numan,

This is not a review of this patch but just a note that OVN's checkpatch
is broken.  Please see below.

> diff --git a/northd/en-lr-nat.h b/northd/en-lr-nat.h
> index 3ec4c7b506..4d8e142ae6 100644
> --- a/northd/en-lr-nat.h
> +++ b/northd/en-lr-nat.h
> @@ -86,6 +86,9 @@ struct lr_nat_table {
>  const struct lr_nat_record * lr_nat_table_find_by_index(
>      const struct lr_nat_table *, size_t od_index);
>  
> +#define LR_NAT_TABLE_FOR_EACH(LR_NAT_REC, TABLE) \
> +    HMAP_FOR_EACH (LR_NAT_REC, key_node, &(TABLE)->entries)
> +

This part causes OVN's checkpatch.py script to spin forever.  We're
missing some OVS fixes.  I posted a patch to port those to OVN here:

https://patchwork.ozlabs.org/project/ovn/patch/[email protected]/

Regards,
Dumitru

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to