On 1/16/24 13:18, Dumitru Ceara wrote: > On 1/11/24 16:29, [email protected] wrote: >> From: Numan Siddique <[email protected]> >> >> This new engine now maintains the NAT related data for each >> logical router which was earlier maintained by the northd >> engine node in the 'struct ovn_datapath'. The input to >> this engine node is 'northd'. >> >> A record for each logical router (lr_nat_record) is maintained >> in the 'lr_nats' hmap table which stores the lr's NAT dat. >> >> 'northd' engine now reports logical routers changed due to NATs >> in its tracking data. 'lr_nat' engine node makes use of >> this tracked data in its northd change handler to update the >> NAT data. >> >> This engine node becomes an input to 'lflow' node. >> >> Signed-off-by: Numan Siddique <[email protected]> >> --- > > Hi Numan, > > Overall the patch seems to be correct. I would make a few changes > though. I left some comments below. > > To make it easier I also pushed those as a patch to my fork: > > https://github.com/dceara/ovn/commit/917b9b64e8a77c07f6dc52c4423a12d71412d9b5 > > Please let me know what you think.
I forgot to mention, if you're ok with the suggested changes, please add my ack: Acked-by: Dumitru Ceara <[email protected]> Thanks! _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
