On Thu, Feb 15, 2024 at 01:00:05PM +0100, Ilya Maximets wrote: > Currently, failures of pthread_* functions are printed to stderr > only and then OVS aborts. These error messages are hard to find > and may be even just lost. > > Use VLOG_ABORT() instead. It will do the same thing, but will try > to log the error to the log file and syslog first, if configured. > > Using VLOG_ABORT() instead of VLOG_FATAL() to preserve the abort() > logic and not just exit with a failure code, because it's likely > we want a core dump if one of these function failed. For example, > we would like to have a stack trace in a core dump in case a mutex > lock failed with 'deadlock avoided'. > > Signed-off-by: Ilya Maximets <[email protected]> > --- > > Another thing we can do to improve debugability is to also dump > the stack trace on ovs_abort. It will also help with debugging > assertions on systems where coredumps are disabled for some reason. > But it's a separate topic.
Acked-by: Simon Horman <[email protected]> ... _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
