On 15 Feb 2024, at 13:00, Ilya Maximets wrote:

> Currently, failures of pthread_* functions are printed to stderr
> only and then OVS aborts.  These error messages are hard to find
> and may be even just lost.
>
> Use VLOG_ABORT() instead.  It will do the same thing, but will try
> to log the error to the log file and syslog first, if configured.
>
> Using VLOG_ABORT() instead of VLOG_FATAL() to preserve the abort()
> logic and not just exit with a failure code, because it's likely
> we want a core dump if one of these function failed.  For example,
> we would like to have a stack trace in a core dump in case a mutex
> lock failed with 'deadlock avoided'.
>
> Signed-off-by: Ilya Maximets <i.maxim...@ovn.org>

Changes look good to me!

Acked-by: Eelco Chaudron <echau...@redhat.com>

//Eelco

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to